Skip to content

Enable 2 round trip receipts#999

Merged
ashamis merged 2 commits intomicrosoft:masterfrom
ashamis:nonce_4
Apr 1, 2020
Merged

Enable 2 round trip receipts#999
ashamis merged 2 commits intomicrosoft:masterfrom
ashamis:nonce_4

Conversation

@ashamis
Copy link
Copy Markdown
Contributor

@ashamis ashamis commented Mar 26, 2020

Each pre-prepare and prepare are given a hash of a nonce and then in the reply we send the plain text nonce to the client-proxy.

To get two-round-trips latency, replicas would return a reply to the client-proxy after getting a pre-prepare and 2f matching prepares. The client-proxy will get its reply and receipt before the request is committed in the ledger, but we guarantee that the request is eventually committed to the ledger or we can prove that some replicas are malicious.

@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

nonce_4@6897 aka 20200401.9 vs master ewma over 50 builds from 6095 to 6892
images

@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

nonce_4@6559 aka 20200326.36 vs master ewma over 30 builds from 6121 to 6551
images

@ashamis ashamis marked this pull request as ready for review March 30, 2020 09:20
@ashamis ashamis requested a review from a team as a code owner March 30, 2020 09:20
@ashamis ashamis changed the title [Draft] Enable 2 round trip receipts Enable 2 round trip receipts Mar 30, 2020
Copy link
Copy Markdown
Contributor

@olgavrou olgavrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although we should probably run these changes combined with #1001 in order to test with the election test and with late joiners + view changes

@ashamis ashamis merged commit 6f7b4dc into microsoft:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants