Fixed arg pairs not correct for old source in module pdbs#3599
Merged
adam-yang merged 3 commits intomicrosoft:masterfrom Mar 18, 2021
Merged
Fixed arg pairs not correct for old source in module pdbs#3599adam-yang merged 3 commits intomicrosoft:masterfrom
adam-yang merged 3 commits intomicrosoft:masterfrom
Conversation
tex3d
reviewed
Mar 18, 2021
| CComPtr<IDxcBlobEncoding> pProgramHeaderBlob; | ||
| IFR(hlsl::DxcCreateBlobWithEncodingFromPinned(program_header, program_header->SizeInUint32*sizeof(UINT32), CP_ACP, &pProgramHeaderBlob)); | ||
| CComPtr<IDxcBlob> pProgramHeaderBlob; | ||
| IFR(hlsl::DxcCreateBlobFromPinned(program_header, program_header->SizeInUint32*sizeof(UINT32), &pProgramHeaderBlob)); |
Contributor
There was a problem hiding this comment.
For both pinned cases, I think we actually want BlobFromBlob (with offset/size).
tex3d
added a commit
that referenced
this pull request
Mar 23, 2021
Cherry-pick changes to release branch: cd3ef21 Roll back llvm::ArrayRef dependency in ExecutionTest (#3613) 2791c51 Generate descriptions for resources with no names (#3598) 22fa209 Fix LifetimeIntrinsicTest issues (#3609) 2039610 Fix Dxil validator compat and test issues (#3610) 220e884 Rename payload qualifier field to not match type (#3607) 0e89206 Correct exception handler sprintf for 32-bit (#3608) 9b475a7 Add dxc exception handler (#3604) e8372b9 Fixed arg pairs not correct for old source in module pdbs (#3599) 2bda44f Add constant evaluation for clamp() (#3581) 640c9af Added way for caller to replace args in PDB utils (#3595) de00b01 Fix const error check for object subscript operator (#3580)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializing args for old PDBs (where sources and args are inside the debug module) was going through a different code path, where arg pairs were not being initialized. This change fixes that.