Merged
Conversation
The most common cause of internal compiler errors are access violations or stack overflows. This registers an exception handler in dxc.exe for these cases that are otherwise unhandled. It prints a simple message for these errors and passes the exception along. In case this is unwanted for some reason, a hidden disabling flag is added as well.
dmpots
approved these changes
Mar 18, 2021
|
✅ Build DirectXShaderCompiler 1.0.4607 completed (commit d24f31d91a by @pow2clk) |
dmpots
reviewed
Mar 18, 2021
added 2 commits
March 18, 2021 17:04
Adds LLVM builtin exceptions for assert, fatal, and unreachable. Adds a default message for exceptions not explicitly addressed. Alters behavior of llvm_unreachable so it always raises an exception regardless of compiler support for unreachable hints. Reports errors using fputs instead of std::cerr to ensure that no allocation is necessary. Custom output is performed in a static array that is output with fputs.
tex3d
reviewed
Mar 19, 2021
tex3d
approved these changes
Mar 19, 2021
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good, with one suggestion.
This is only applicable to dxc. So it needn't be core (yet)
|
✅ Build DirectXShaderCompiler 1.0.4616 completed (commit 5fdd2d8a4e by @pow2clk) |
tex3d
pushed a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Mar 22, 2021
The most common cause of internal compiler errors are access violations or stack overflows. This registers an exception handler in dxc.exe for these cases that are otherwise unhandled. It prints a simple message for these errors and passes the exception along. In case this is unwanted for some reason, a hidden disabling flag is added as well. Adds LLVM builtin exceptions for assert, fatal, and unreachable. Adds a default message for exceptions not explicitly addressed. Alters behavior of llvm_unreachable so it always raises an exception regardless of compiler support for unreachable hints. Reports errors using fputs instead of std::cerr to ensure that no allocation is necessary. Custom output is performed in a static array that is output with fputs. (cherry picked from commit 9b475a7)
tex3d
added a commit
that referenced
this pull request
Mar 23, 2021
Cherry-pick changes to release branch: cd3ef21 Roll back llvm::ArrayRef dependency in ExecutionTest (#3613) 2791c51 Generate descriptions for resources with no names (#3598) 22fa209 Fix LifetimeIntrinsicTest issues (#3609) 2039610 Fix Dxil validator compat and test issues (#3610) 220e884 Rename payload qualifier field to not match type (#3607) 0e89206 Correct exception handler sprintf for 32-bit (#3608) 9b475a7 Add dxc exception handler (#3604) e8372b9 Fixed arg pairs not correct for old source in module pdbs (#3599) 2bda44f Add constant evaluation for clamp() (#3581) 640c9af Added way for caller to replace args in PDB utils (#3595) de00b01 Fix const error check for object subscript operator (#3580)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most common cause of internal compiler errors are access violations
or stack overflows. This registers an exception handler in dxc.exe for
these cases that are otherwise unhandled. It prints a simple message
for these errors and passes the exception along.
In case this is unwanted for some reason, a hidden disabling flag is
added as well.