Correct exception handler sprintf for 32-bit#3608
Merged
pow2clk merged 1 commit intomicrosoft:masterfrom Mar 19, 2021
Merged
Conversation
The size of ULONG_PTR varies based on the address size of the architecture. For 32-bit systems, it was invalid to treat it like a 64-bit value. By casting the value to a void pointer and changing the print code to %p, we get the right thing for all platforms
|
✅ Build DirectXShaderCompiler 1.0.4619 completed (commit 872378dac0 by @pow2clk) |
tex3d
pushed a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Mar 22, 2021
The size of ULONG_PTR varies based on the address size of the architecture. For 32-bit systems, it was invalid to treat it like a 64-bit value. By casting the value to a void pointer and changing the print code to %p, we get the right thing for all platforms (cherry picked from commit 0e89206)
tex3d
added a commit
that referenced
this pull request
Mar 23, 2021
Cherry-pick changes to release branch: cd3ef21 Roll back llvm::ArrayRef dependency in ExecutionTest (#3613) 2791c51 Generate descriptions for resources with no names (#3598) 22fa209 Fix LifetimeIntrinsicTest issues (#3609) 2039610 Fix Dxil validator compat and test issues (#3610) 220e884 Rename payload qualifier field to not match type (#3607) 0e89206 Correct exception handler sprintf for 32-bit (#3608) 9b475a7 Add dxc exception handler (#3604) e8372b9 Fixed arg pairs not correct for old source in module pdbs (#3599) 2bda44f Add constant evaluation for clamp() (#3581) 640c9af Added way for caller to replace args in PDB utils (#3595) de00b01 Fix const error check for object subscript operator (#3580)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size of ULONG_PTR varies based on the address size of the
architecture. For 32-bit systems, it was invalid to treat it like a
64-bit value. By casting the value to a void pointer and changing the
print code to %p, we get the right thing for all platforms