Cherry-pick of changes for PIX Early 2023 Release#4944
Merged
hekota merged 5 commits intomicrosoft:release-1.7.2212from Jan 14, 2023
Merged
Cherry-pick of changes for PIX Early 2023 Release#4944hekota merged 5 commits intomicrosoft:release-1.7.2212from
hekota merged 5 commits intomicrosoft:release-1.7.2212from
Conversation
* Account for alignment * Use llvm::RoundUpToAlignment
…#4929) In the lib case, m_EntryPoint will be non-null but empty, but shouldn't be set anyway. (Also, not clearing m_EntryPoint first can result in an assert in CComPtr that the poiner is non-null, and then the pointer is overwritten, resulting in a small memory leak.)
…icrosoft#4937) These fixes were the result of a single shader from a well-known game engine, all of which resulted in mismatched offsets between PIX's offsets-into-fake-allocas and the offsets into aggregates for dbg.value statements. -Base class sizes weren't being added to derived classes -Samplers+Resources weren't being given any size at all -Raygen payloads (referred to by pointer) were triggering an assert Added a new set of tests for the type system to exercise these.
hekota
approved these changes
Jan 13, 2023
Member
hekota
left a comment
hekota
left a comment
There was a problem hiding this comment.
Please change the name of the PR/merge commit message to something more descriptive. Otherwise LGTM!
|
✅ Build DirectXShaderCompiler 1.0.2606 completed (commit affe43d583 by @jeffnn) |
hekota
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.