Skip to content

Fix path issue with spaces#331

Merged
walbourn merged 1 commit into
microsoft:mainfrom
waruqi:patch-1
Aug 25, 2022
Merged

Fix path issue with spaces#331
walbourn merged 1 commit into
microsoft:mainfrom
waruqi:patch-1

Conversation

@waruqi
Copy link
Copy Markdown
Contributor

@waruqi waruqi commented Aug 25, 2022

user account containing 'firstName + whitespace + lastName'. It will build fails

Generating HLSL shaders... 'Lastname' is not recognized as an internal or external command, operable program or batch file

see xmake-io/xmake#2714 (comment)

@walbourn walbourn merged commit d2398c0 into microsoft:main Aug 25, 2022
@waruqi waruqi deleted the patch-1 branch August 25, 2022 02:21
@walbourn walbourn self-assigned this Aug 25, 2022
@walbourn walbourn added the bug label Aug 25, 2022
@walbourn
Copy link
Copy Markdown
Member

Thanks for the investigation and fix!

BTW, fixed the same issue in CompileShaders.cmd in my other repos:

microsoft/DirectXTex@3382be5

microsoft/DirectXTK12@6a080f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants