Fix shader output path quoting for paths containing spaces#704
Merged
Conversation
Member
|
Thanks for the contribution. Can you do the same for DirectXTK and DirectXTK12? |
Contributor
Author
|
Thanks for the review. I'll submit similar fixes for DirectXTK and DirectXTK12 shortly. |
Contributor
Author
|
The same fix was already applied to DirectXTK via PR #331 (commit d2398c0, Aug 2022) and to DirectXTK12 via commits e333077/6a080f3 (Nov 2021 / Aug 2022). Both repos already quote all CompileShadersOutput paths in CompileShaders.cmd. The hlsl.cmd was the last remaining instance of this issue. |
Member
|
Thanks for checking! |
Member
walbourn
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.