fix: merging dev to main#434
Merged
Merged
Conversation
… auth status and improve code readability
…essage for signed-in users
feat: Add User Profile Menu and Logout Option
…update related comments and method calls. Co-authored-by: Copilot <copilot@github.com>
…e deployment details such as triggered by and branch information Co-authored-by: Copilot <copilot@github.com>
…r WAF configuration Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…pp_url input Co-authored-by: Copilot <copilot@github.com>
…nput feat: Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut
Azure no longer supports enabling Analytical Storage during Cosmos DB account creation, which caused deployments to fail with: BadRequest: Enabling Analytical Storage during account creation is no longer supported. The flag was set to true in infra/modules/cosmosDb.bicep but no container in this solution configures analyticalStorageTtl, so the feature was unused. Removing the explicit value lets the AVM module default (false) apply, unblocking deployments. Regenerated infra/main.json from the updated Bicep. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…torage fix(infra): remove enableAnalyticalStorage on Cosmos DB account creation
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a WAF-only scalability toggle through the deployment workflow path, updates deployment notifications/tagging, removes a Cosmos DB module parameter, and adds an authenticated user profile menu to the frontend header.
Changes:
- Adds
enable_scalabilityinputs and propagation through deployment orchestration and OS-specific deploy jobs. - Updates notification email formatting and resource group Owner tagging behavior.
- Adds frontend
UserProfilerendering when auth is enabled and removes Cosmos DB analytical storage parameter usage.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/msal-auth/useAuth.ts |
Renames logout API to signOut and updates messages. |
src/frontend/src/components/Header/UserProfile.tsx |
Adds authenticated user menu/avatar with sign-out action. |
src/frontend/src/components/Header/Header.tsx |
Conditionally renders the user profile in the header toolbar. |
src/frontend/declarations.d.ts |
Adds global typing for runtime app config. |
infra/modules/cosmosDb.bicep |
Removes Cosmos DB analytical storage parameter. |
infra/main.json |
Regenerates ARM output for infra changes. |
.github/workflows/job-send-notification.yml |
Reworks notification email HTML/status presentation. |
.github/workflows/job-deploy.yml |
Adds scalability input propagation and Owner tagging. |
.github/workflows/job-deploy-windows.yml |
Applies WAF scalability parameter update on Windows deployments. |
.github/workflows/job-deploy-linux.yml |
Applies WAF scalability parameter update on Linux deployments. |
.github/workflows/deploy-v2.yml |
Adds/validates scalability workflow input and passes it onward. |
.github/workflows/deploy-orchestrator.yml |
Passes scalability input into the deploy job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ritesh-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Ritesh-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Ritesh-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Ritesh-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prajwal-Microsoft
approved these changes
May 18, 2026
Roopan-Microsoft
approved these changes
May 18, 2026
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces support for an "Enable Scalability" option across multiple deployment workflows, refines input validation and parameter handling, and improves resource group tagging. It also includes minor infrastructure and frontend updates. The main focus is to allow users to toggle scalability features (when WAF is enabled) via workflow inputs, propagate this setting through deployment logic, and ensure robust validation and parameterization.
Deployment Workflow Enhancements:
Added
enable_scalability/ENABLE_SCALABILITYinput to.github/workflows/deploy-v2.yml,.github/workflows/deploy-orchestrator.yml,.github/workflows/job-deploy.yml,.github/workflows/job-deploy-linux.yml, and.github/workflows/job-deploy-windows.yml, with validation to ensure it is only effective when WAF is enabled. This input is now passed through all relevant job/environment variables and validated for correctness. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]In Linux and Windows deployment jobs, added logic to update the ARM parameters file (
infra/main.parameters.json) with theenableScalabilityvalue usingjq, only when WAF is enabled, and with input validation. [1] [2]Resource Group Tagging Improvements:
.github/workflows/job-deploy.ymlto always add or update anOwnertag (using${{ github.actor }}) on the resource group, both on creation and update, for better traceability.Infrastructure Template Updates:
infra/main.jsonto ensure correct resource deployment order for private DNS zones. [1] [2]enableAnalyticalStorageparameter from the Cosmos DB module and template. [1] [2]Frontend Minor Update:
UserProfilecomponent inHeader.tsxand added logic to conditionally render it only when authentication is enabled, based on the runtime configuration. [1] [2]Other Minor Improvements:
These changes collectively improve deployment flexibility, robustness, and maintainability for environments that require scalable infrastructure and enhanced resource management.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information