Skip to content

fix(sleep): validate proposal content before staging - #210

Merged
Yifan Yang (Yif-Yang) merged 1 commit into
microsoft:mainfrom
Yif-Yang:fix/pr188-proposal-prevalidation
Aug 9, 2026
Merged

fix(sleep): validate proposal content before staging#210
Yifan Yang (Yif-Yang) merged 1 commit into
microsoft:mainfrom
Yif-Yang:fix/pr188-proposal-prevalidation

Conversation

@Yif-Yang

Copy link
Copy Markdown
Contributor

Follow-up to #188.

Validate every proposed skill body before creating the output directory or writing any staged file. This prevents a later non-text proposal from raising TypeError after earlier proposals have already been persisted, and preserves the documented no-partial-files contract for invalid input.

Regression coverage exercises a valid first proposal followed by an invalid body and asserts that staging remains empty.

Validation:

  • focused fan-out suite: 21 passed
  • full test suite: 920 passed, 6 skipped, 130 subtests passed
  • Ruff: passed

Refs #188.

@Yif-Yang
Yifan Yang (Yif-Yang) merged commit de2b732 into microsoft:main Aug 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant