Skip to content

fix(sleep): validate proposal content before staging #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yifan Yang (Yif-Yang) merged 1 commit into from
Aug 9, 2026
+14 −0
Merged

fix(sleep): validate proposal content before staging #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions skillopt_sleep/staging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,11 @@ def skill_proposal_rows(proposals: Iterable[SkillProposal]) -> List[Dict[str, An
name = _safe_skill_name(proposal.skill_name)
if not name:
raise StagingError(f"unsafe skill name for staging: {proposal.skill_name!r}")
if not isinstance(proposal.proposed_skill, str):
raise StagingError(
f"proposed skill content for {name!r} must be text, "
f"got {type(proposal.proposed_skill).__name__}"
)
live = _safe_live_path(proposal.live_skill_path)
if not live:
raise StagingError(
Expand Down
9 changes: 9 additions & 0 deletions tests/test_sleep_staging_fanout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,15 @@ def test_rejected_fan_out_leaves_no_partial_files(self):
write_skill_proposals(tmp, [_proposal("alpha"), _proposal("../escape")])
self.assertEqual(os.listdir(tmp), [])

def test_non_text_proposal_leaves_no_partial_files(self):
with tempfile.TemporaryDirectory() as tmp:
with self.assertRaisesRegex(StagingError, "must be text"):
write_skill_proposals(
tmp,
[_proposal("alpha", "# alpha\n"), _proposal("beta", None)],
)
self.assertEqual(os.listdir(tmp), [])

def test_writes_leave_no_temporary_files_behind(self):
with tempfile.TemporaryDirectory() as tmp:
write_skill_proposals(tmp, [_proposal("alpha")])
Expand Down