[Fabric] Add DetailsList, GroupItem, and MarqueeSelection components (#37) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d changeable-item/changeable-items directives
bengry
suggested changes
Nov 13, 2018
libs/fabric/src/lib/components/marquee-selection/marquee-selection.component.ts
Show resolved
Hide resolved
libs/fabric/src/lib/components/marquee-selection/marquee-selection.component.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/marquee-selection/marquee-selection.component.ts
Show resolved
Hide resolved
libs/fabric/src/lib/components/details-list/details-list.component.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/details-list/directives/details-list-columns.directive.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/details-list/directives/details-list-columns.directive.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/details-list/directives/details-list-groups.directive.ts
Outdated
Show resolved
Hide resolved
…dBarItem and ContextualMenuItem to use new pattern, Changed component property organization, Ran Prettier on touched files
bengry
suggested changes
Nov 16, 2018
libs/fabric/src/lib/components/core/shared/changeable-helper.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/core/shared/changeable-helper.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/core/shared/changeable-helper.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/core/shared/changeable-item.directive.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/core/shared/changeable-items.directive.ts
Outdated
Show resolved
Hide resolved
bengry
approved these changes
Nov 18, 2018
Contributor
|
@xjerwa Approved. Feel free to merge whenever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fabric] Add DetailsList, GroupItem, and MarqueeSelection components (#37)
Also created changeable-item and changeable-items for ease of adding directives in the future