Skip to content

Conversation

@bengry
Copy link
Contributor

@bengry bengry commented Nov 16, 2018

  • Package upgrades (non-breaking)
  • Align repo to Prettier 1.15
    • [includes] Revert decorators to their previous position in components, before the change in 1.14.

@bengry bengry changed the title Change to Yarn, Package upgrades, Prettier alignment Package upgrades, Prettier alignment Nov 16, 2018
@xjerwa
Copy link
Contributor

xjerwa commented Nov 19, 2018

Looks like it's mainly whitespace/newline changes. I think there were a few discrepancies in Prettier formatting for the new files from PR#37 such as same-line @Input and @Output declarations

@bengry
Copy link
Contributor Author

bengry commented Nov 19, 2018

@xjerwa Yep, Prettier is mainly that - formatting the code for you, so you don't have to think about it.
I'll rebase on top of master now that #37 is merged.

# Conflicts:
#	libs/fabric/src/lib/components/command-bar/command-bar.component.ts
#	libs/fabric/src/lib/components/command-bar/directives/command-bar-items.directives.ts
#	libs/fabric/src/lib/components/contextual-menu/directives/contextual-menu-item.directive.ts
@bengry bengry merged commit 68f3581 into master Dec 1, 2018
@bengry bengry deleted the prettier-upgrade branch December 1, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants