Skip to content

ci: temporarily disable flaky VS Code extension E2E tests - #18413

Merged
Ankit Jain (radical) merged 1 commit into
microsoft:mainfrom
radical:ankj/disable-vs-e2e
Jun 22, 2026
Merged

ci: temporarily disable flaky VS Code extension E2E tests#18413
Ankit Jain (radical) merged 1 commit into
microsoft:mainfrom
radical:ankj/disable-vs-e2e

Conversation

@radical

Copy link
Copy Markdown
Member

The VS Code extension E2E tests are flaky and currently failing in CI, blocking unrelated PRs. The zero-to-running shard intermittently fails in its after each teardown:

1) Aspire zero-to-running E2E
     "after each" hook ...:
   AggregateError: Zero-to-running E2E teardown failed.

(tracked in #18098). Because the extension_e2e_tests job gates CI, this flakiness fails runs on PRs that don't touch the extension.

The fix

Temporarily disable the extension_e2e_tests job in tests.yml:

  • Force the job to always skip via if: ${{ false && … }} (keeping the run_extension_e2e reference so the trigger-map binding test stays valid).
  • Remove the two aggregate-gate clauses (PR + non-PR) that treat a skipped e2e job as a failure, so the forced skip doesn't fail the overall gate.

Extension unit tests (extension_tests_win, extension_bootstrap_linux) are unaffected and still run.

Re-enabling

Tracked by #18412. Revert: drop the false && guard and restore the two gate clauses, after the flakiness in #18098 is fixed.

Refs #18098

The VS Code extension E2E tests are flaky and currently failing in CI,
blocking unrelated PRs. The zero-to-running shard intermittently fails
in its "after each" teardown with an AggregateError on Windows (microsoft#18098),
and because the extension_e2e_tests job gates CI, this fails runs on PRs
that don't touch the extension.

Temporarily disable the extension_e2e_tests job in tests.yml:

- Force the job to always skip via `if: ${{ false && ... }}`, keeping the
  run_extension_e2e reference so the trigger-map binding test stays valid.
- Remove the two aggregate-gate clauses (PR + non-PR) that treat a skipped
  e2e job as a failure, so the forced skip doesn't fail the overall gate.

Extension unit tests (extension_tests_win, extension_bootstrap_linux) are
unaffected and still run.

Re-enabling is tracked by microsoft#18412.

Refs microsoft#18098

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 22, 2026 23:08
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18413

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18413"

@radical
Ankit Jain (radical) marked this pull request as ready for review June 22, 2026 23:10
@radical
Ankit Jain (radical) enabled auto-merge (squash) June 22, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables the flaky extension_e2e_tests job in .github/workflows/tests.yml. The zero-to-running E2E shard intermittently fails in its after each teardown with an AggregateError (tracked in #18098), and because the job gates CI, it was failing unrelated PRs. The job is force-skipped while keeping it wired into the workflow so the trigger-map binding test stays valid, and the aggregate-gate clauses that treat a skipped E2E job as a failure are removed. Re-enabling is tracked by #18412.

Changes:

  • Force extension_e2e_tests to always skip via if: ${{ false && needs.setup_for_tests.outputs.run_extension_e2e == 'true' }}, retaining the run_extension_e2e reference so the binding test still passes.
  • Remove the PR and non-PR aggregate-gate clauses that fail CI when extension_e2e_tests is skipped.
  • Update surrounding comments to explain the temporary disable and how to revert.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@radical
Ankit Jain (radical) merged commit d619e31 into microsoft:main Jun 22, 2026
643 of 647 checks passed
@github-actions github-actions Bot added this to the 13.5 milestone Jun 22, 2026
David Fowler (davidfowl) pushed a commit that referenced this pull request Jun 29, 2026
The extension E2E shards (specifically Windows, debug-dashboard) are
consistently failing on main, blocking unrelated PRs from merging.

Recent failures on main (last 5 days):
- CI #25637 (Jun 28): Update OpenTelemetry.Instrumentation.StackExchangeRedis
- CI #25621 (Jun 27): Prepare VS Code extension release v1.16.0
- CI #25616 (Jun 27): Fix VS Code extension CLI install
- CI #25543 (Jun 26): Make dashboard launch opt-in by default

Adds a `false &&` guard to the extension_e2e_tests job condition and
removes the corresponding gate skip-checks, following the same pattern
as PR #18413.

Tracked by #18412.
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants