Disable VS Code extension E2E tests in CI - #18547
Conversation
The extension E2E shards (specifically Windows, debug-dashboard) are consistently failing on main, blocking unrelated PRs from merging. Recent failures on main (last 5 days): - CI #25637 (Jun 28): Update OpenTelemetry.Instrumentation.StackExchangeRedis - CI #25621 (Jun 27): Prepare VS Code extension release v1.16.0 - CI #25616 (Jun 27): Fix VS Code extension CLI install - CI #25543 (Jun 26): Make dashboard launch opt-in by default Adds a `false &&` guard to the extension_e2e_tests job condition and removes the corresponding gate skip-checks, following the same pattern as PR #18413. Tracked by #18412.
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18547Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18547" |
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables the consistently-failing VS Code extension E2E test job in CI so it stops blocking unrelated PRs from merging. It mirrors the approach used in #18413: the job is kept defined (so the aggregate gate's needs and the trigger-map binding test stay valid) but is forced to skip, and the gate is updated so the forced skip is not treated as a failure.
Changes:
- Adds a
false &&guard toextension_e2e_tests.ifso the job always skips, with a comment pointing to the tracking issue #18412 and flakiness issue #18098. - Removes the two aggregate-gate clauses (PR + non-PR) that treated a skipped
extension_e2e_testsas a failure. - Updates the gate documentation to explain why the job is intentionally skipped.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. Runs the full test matrix + all jobs (ALL) — a rule matching '.github/workflows/tests.yml' selects ALL Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
✅ No documentation update needed. docs_optional → build_or_ci_only No documentation signals triggered (signal_count = 0). The sole changed file ( |
Description
The VS Code extension E2E tests (specifically the
Windows, debug-dashboardshard) are consistently failing on main, blocking unrelated PRs from merging.This PR adds a
false &&guard to theextension_e2e_testsjob condition and removes the corresponding gate skip-checks, following the same pattern as #18413.Recent failures on main (last 5 days)
VS Code extension E2E (Windows, debug-dashboard)VS Code extension E2E (Windows, debug-dashboard)VS Code extension E2E (Windows, debug-dashboard)VS Code extension E2E (Windows, debug-dashboard)Tracked by #18412