Rename Azure scope factories - #18976
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c2c7da0-b7e0-477d-b7b2-3f3f3809d8c2
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18976Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18976" |
There was a problem hiding this comment.
Pull request overview
Renames Azure Bicep scope factories to follow .NET verb-phrase naming guidelines.
Changes:
- Renames factories to
CreateForSubscriptionandCreateForTenant. - Updates internal usage and all C# tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Hosting.Azure/AzureBicepResourceScope.cs |
Renames scope factories and internal calls. |
tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs |
Updates existing-resource scope calls. |
tests/Aspire.Hosting.Azure.Tests/BicepUtilitiesTests.cs |
Updates scope utility tests. |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceTests.cs |
Updates environment scope calls. |
tests/Aspire.Hosting.Azure.Tests/AzureBicepProvisionerTests.cs |
Updates provisioning scope calls. |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 11 / 100 test projects · 3 jobs, from 5 changed files. Selected test projects (11 / 100)
Selected jobs (3)
How these were chosen — grouped by what changed
🔧 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
|
Pull request created: #1451
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1451 targeting Added a new Set the deployment scope section to
Note This draft PR needs human review before merging. |
PR microsoft#19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR microsoft#18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from microsoft#18976 rather than reintroducing the old factory names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR #19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR #18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from #18976 rather than reintroducing the old factory names. Co-authored-by: adamint <adamratzman1@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
Aligns the new Azure Bicep resource scope factories with .NET member naming guidelines before they ship.
ForSubscriptionandForTenantare renamed to the verb-phrase names requested in API review:CreateForSubscriptionandCreateForTenant.The implementation and all C# call sites are updated. Existing TypeScript capability generation remains unchanged because these factories are not exported as generated-language capabilities.
User-facing usage
Validation:
Aspire.Hosting.Azure.Teststests passed.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?