Preserve Azure Bicep scope API compatibility - #19084
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a4388e40-626f-4e1a-b980-bf079acdd8d5
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19084Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19084" |
github-actions
Bot
added
the
area-app-model
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 11 / 100 test projects · 3 jobs, from 7 changed files. Selected test projects (11 / 100)
Selected jobs (3)
How these were chosen — grouped by what changed
🔧 🧪 🔧 🔧 🔧 🔧 🔧 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
✅ No documentation update needed. Step 5 branch taken: Triggered signals: none ( Rationale: This PR fixes a regression introduced by an earlier change (#17988) that made All 7 changed files are under This is an internal correctness fix (restoring prior public API shape) with no new user-facing surface — matches the |
|
The CI build failed due to test failure(s) that appear unrelated to the PR changes. These may be flaky tests. Suspected flaky test(s):
Suggested actions:
You can re-run the failed jobs from the workflow run page. |
PR microsoft#19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR microsoft#18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from microsoft#18976 rather than reintroducing the old factory names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR #19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR #18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from #18976 rather than reintroducing the old factory names. Co-authored-by: adamint <adamratzman1@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
#17988 made
AzureBicepResourceScope.ResourceGroupnullable to represent subscription- and tenant-scoped deployments, which breaks the existing public API contract. This restores the shipped non-nullableobject ResourceGroupproperty while keeping the new scope scenarios working.Subscription and tenant scopes now model resource-group absence internally with
HasResourceGroup. Internal publishing and provisioning paths check that state before accessingResourceGroup, whose public getter throws when the selected scope does not target a resource group. Focused tests cover resource-group, subscription, and tenant behavior.Validated with the targeted Azure hosting scope tests and a Release build of
Aspire.Hosting.Azure.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?