Fix docs PR generation for release branches - #19055
Conversation
Use the resolved aspire.dev branch for agent-time patch generation, preserve root cross-repository workspaces, and remove the duplicate release-support checkout. Upgrade and recompile all gh-aw workflows with v0.85.4. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19055Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19055" |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. Runs the full test matrix + all jobs (ALL) — run-all fallback: '.gitattributes' is neither Layer-1-owned nor matched by a Layer 2 rule Selection computed for commit |
There was a problem hiding this comment.
🔵 Human review recommended
Cross-repository PR generation and compiler-wide workflow changes require final human validation despite no concrete defects found.
Pull request overview
Fixes #19054 by aligning documentation patch generation with the dynamically resolved Aspire docs release branch.
Changes:
- Exposes and uses the effective docs branch, with a safe-output
mainfallback. - Removes duplicate
aspire.devagent checkout behavior. - Upgrades and recompiles all gh-aw workflows to v0.85.4.
File summaries
| File | Description |
|---|---|
.github/workflows/pr-docs-check.md |
Wires the resolved docs branch into patch generation. |
.github/workflows/release-update-support-mdx.md |
Uses one root agent checkout. |
.github/workflows/analyze-ci-failure.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/daily-repo-status.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/extension-changelog.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/milestone-changelog.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/pr-docs-check.lock.yml |
Contains the compiled dynamic-base fix. |
.github/workflows/release-notes-generate.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/release-update-support-mdx.lock.yml |
Contains the compiled checkout fix. |
.github/workflows/repo-pulse.lock.yml |
Recompiled with gh-aw v0.85.4. |
.github/workflows/agentics-maintenance.yml |
Removes obsolete generated maintenance workflow. |
.github/workflows/agentics-maintenance-microsoft-aspire.dev.yml |
Regenerates side-repository maintenance. |
.github/aw/actions-lock.json |
Updates gh-aw action pins. |
.gitattributes |
Removes the custom merge strategy for generated locks. |
Review details
- Files reviewed: 10/14 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Description
PR Documentation Checkhas authored and committed documentation for release-bound changes, then failed before opening the Aspire docs PR. Issue #19054 now tracks 35 confirmed release/13.5 failures; 31 still need recovery.gh-aw patch generation uses the workflow's configured
base-branchbefore it can honor the agent's per-callbase. The workflow configuredmain, while its depth-1 workspace was based onrelease/13.5, sogit merge-basecould not traverse the shallow boundary and returnedERR_SYSTEM. Fetching full history is not a safe workaround because it could produce a patch containing the entire main-to-release divergence.This change:
mainfallback in the separate safe-output job, where the handler still honors the allowlisted per-call release base while applying the patch;aspire.devagent checkout fromrelease-update-support-mdx, which could shadow the checkout containing the authored branch;The upstream dynamic-base limitation remains open in github/gh-aw#41265. v0.85.4 includes the separate re-shallowing fix from github/gh-aw#50378, but upgrading alone does not resolve dynamic patch-base selection.
Validation:
fetch-depth: 0.main.After this merges, affected source PRs need a fresh
workflow_dispatch; GitHub's Re-run jobs action would reuse the old workflow revision. The recovery inventory and resulting Aspire docs PRs will be tracked in #19054.GH_AW_GITHUB_TOKENsecret is not configured #18615Checklist
<remarks />and<code />elements on your triple slash comments?