Fix gh-aw docs PR push permissions - #19062
Conversation
Remove redundant custom target checkouts that trigger github/gh-aw#50905 and downgrade the cross-repository app token to contents:read. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19062Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19062" |
There was a problem hiding this comment.
Pull request overview
Removes redundant gh-aw checkouts that downgraded permissions and prevented documentation PR branches from being pushed.
Changes:
- Removes custom target-repository checkout steps.
- Regenerates workflows with
contents: write. - Preserves compiler-managed checkout and credential handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pr-docs-check.md |
Removes redundant docs checkout configuration. |
.github/workflows/pr-docs-check.lock.yml |
Regenerates workflow permissions and checkout steps. |
.github/workflows/release-update-support-mdx.md |
Removes redundant support-docs checkout configuration. |
.github/workflows/release-update-support-mdx.lock.yml |
Regenerates workflow with write permissions. |
Describe the compiler-generated target checkout at the safe-output workspace root. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Description
The first documentation recovery after #19055 generated the correct
release/13.5patch, but gh-aw could not push the Aspire docs branch. In v0.85.4, anactions/checkoutentry insafe-outputs.stepsoverwrites thecontents: writepermission required bycreate-pull-requestwithcontents: read. Both branch creation paths then fail with 403, and gh-aw creates a fallback issue instead of a docs PR.This removes the redundant custom target-repository checkout from both cross-repository docs workflows. gh-aw already generates the
_repos/aspire.devcheckout forcreate-pull-request; keeping that checkout compiler-owned preserves the handler-derivedcontents: writescope without giving the agent job write access.The compiler defect is tracked by github/gh-aw#50905. The recovery evidence is run 31116010823 and its fallback aspire.dev#1432.
All eight gh-aw workflows were recompiled with the checksum-verified v0.85.4 binary. Schema validation succeeded, and the generated
pr-docs-checkandrelease-update-support-mdxsafe-output jobs now mintpermission-contents: write.Related to #19054
Checklist
<remarks />and<code />elements on your triple slash comments?