Conversation
* update overview and sidebar * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * add architectural benefits --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: darrenge <darrenge@microsoft.com>
--- updated-dependencies: - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: darrenge <darrenge@microsoft.com>
Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 10.0.100 to 10.0.101. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v10.0.100...v10.0.101) --- updated-dependencies: - dependency-name: dotnet-sdk dependency-version: 10.0.101 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: darrenge <darrenge@microsoft.com>
…1482) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: darrenge <darrenge@microsoft.com>
* Migrate Garnet to .slnx solution format * Revised documentation and .NET build related comments * Rename Tsavorite native device project to avoid confusion * Migrate Tsavorite to .slnx * Update more build related docs to latest tooling * Clean up solution file items --------- Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* Check helm-docs binary release digest in CI * Use FILENAME variable in tar command Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: darrenge <darrenge@microsoft.com>
* The red and teal colors in code samples in docs are now being flagged in high contrast accessibility issues. Updating the custom.css fixes things. * Made changes based on CoPilot suggestions
* Fix exception paths in state machine driver * update version * improvement * make last version stuff private fields * refactor
Bumps [undici](https://github.com/nodejs/undici) from 7.16.0 to 7.18.2. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.16.0...v7.18.2) --- updated-dependencies: - dependency-name: undici dependency-version: 7.18.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Support DNS based clustering * Fix typo * Fix formatting * change default hostname is "" * change `FormatValueOrNull` to local method * Add Null String for CmdStrings.cs * Refactor CreateNodeNetworkingInfo to use StringBuilder * rename unknown-enpoint -> endpoint * Refactor Simplyfy CreateNodeNetworkingInfo * Fix Format * Add handling for Unknown endpoint type in ClusterConfig * Make FormatValueOrNull static in ClusterConfig * Use Format.GetHostName for empty hostname in ClusterManager * Remove preferred endpoint type parameter from Redirect method in RespClusterSlotManagementCommands and RespClusterSlotVerify * Refactor ClusterManagementTests and ClusterRedirectTests to remove target endpoint assertions and improve endpoint validation * Fix ClusterManagementTests to simplify hostname assertions and improve clarity * Refactor FormatValueOrNull Ragne change to local method --------- Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com>
* Scripts running successfully on local machine. Next step is to get them running in GH action
* First attempt at running things in a github action nightly run - using mock data for allure results for now
* Changed how allure being installed
* Added Allure to path
* Path issue ...
* Had test data in wrong spot so wasn't checkd in
* Fix the final stage
* Fixed some paths that had collisions
* Fixing another path collision
* Updated pipeline-success at the end as
* case sensitive issue with running script
* Add debug code
* Need add check out
* Updated how Allure report generation is called
* Need to install Alure in the final step areas as well
* Remove part about saving history and also don't run tests as not needed since mock data
* Move results
* Fixing path issue
* Getting results in couple configs of tests ... bump up matrix by adding debug and cluster tests
* Full matrix
* Adding Allure CLI install to work on Linux too
* Trying debug while allure not installing on linux
* More debugging
* More debugging
* More debugging
* Install Allure CLI should work now
* Fix the Copy of Mock data on linux
* More changes to work on linux
* Fixed upload artifacts call
* fixed a bug in the upload results
* Fix call to GenerateAllureReport in final stages
* Fixed so will retain history ... not actually pushing to repo though yet.
* First step of merging Tsav into other tests so all in one matrix - reduces allure duplication
* second phase ... Getting them merged into one more so -
* Fixed build of Garnet and Garnet cluster
* Fixed bug and added debug info
* Bug fix
* Set it so does everything from build and run tests.
* Cleaned up old code not used any more and made it so all Allure tasks all run even if fails in tests
* Set the final job to always run even if previous job fails
* Removed the test data
* Trying to get Allure nuget incorporated ... build issues
* Minor change
* Upgraded Allure to 2.14 and set <AspectInjector_Enabled>false</AspectInjector_Enabled> for the Garnet.test.csproj due to but in AspectInjector
* Updated all the project files so AspectInjector is disabled
* Got latest update of Allure which fixes their bug. So, can remove the work around where AspectInjector was disabled.
* Added Allure to ObjectTestForOuptut tests as initial try
* Removed style check for now
* Had to add disable the Inspector nuget package for Allure since it can't be built by Core.
* Added the AllureSetup to Garnet.Test (in AllureUtils.cs). Added Allure to handful of tests to try it.
* Merged main into branch and update Garnet.Tests to use AllureTestBase class for logging. Some tests already inheriting different base class so will do those later
* Removed the timestamp from suite name
* Just making suite name with date instead of full time stamp
* Added Allure to Tsav tests
* Made it so Tsav tests can just link to AllureUtils.cs in Garnet.test instead of making copy
* Updated Tsav Test to skip AspectInjector nuget package so it can be run in DotNet Core. AspectInjector is part of Allure but not needed for us
* Minor text change
* Added Tsav to GetData
* Starting the early stages of saving off history
* Minor change
* Fixed merge conflict in Directory.Packages.props
* Setting Check Style Format to show as pass always -- need to fix formatting issues at later point
* Adding yml code to preserve the history between runs
* Some error handling on download history call
* Trying to preserve history by committing to allure_data_history branch
* Perms issues when pushing History to branch
* Bug in the part that gets history saved from branch
* Fixed bug ... not sure fixes other issues
* Minor change
* Clean up debugging
* Debugging the copy of previous history
* Hoping this fixes the copy from previous history.
* Debuggin the copy prev results
* Debugging copy from branch
* More debugging
* More debugging
* Might have it ...
* Cleaning up debug info
* History is working. Move report to GH Website location so front page can see it
* Adding full test matrix to it now -- see how history handles it
* Making it work for Tsavorite
* Fixed bug in output
* Fixed Tsav nightly bug AND also updated readme.md so that there is an Allure Report button on the front
* Tsav working in Allure now ... running cluster to make sure all those picked up properly.
* Cluster seems to run ok ... now full matrix
* Comment out uploading Allure test results to artifacts as hitting upper ceiling
* Just Tsav tests to test history
* Fixed Format issues
* Fix format issues with Tsav tests
* Changing naming method for Allure tests.
* Reduce down to just ubuntu ... debugging name. Maybe caused when removed this:
- name: Upload Allure Results to artifacts
* Trying bigger matrix in hopes not overloading Upload Allure Results to artifacts
* increase matrxi to see if won't hit max
* Set OS to Latest instead of specify all OS
* Updated so Garnet.test and Garnet.test.cluster tests inherit the Allure base class
* Added Allure to ClusterSlotVerificationTests
* Mistake in merge conflict with nuget packages in cluster tests. Fixed
* Need to set:
<AspectInjector_Enabled>false</AspectInjector_Enabled>
In cluster test csproj
* Fixed a couple environmental fixes that were related to looking for specific versions instead of "latest"
* Fixed bug in reporting
* Removing History ID as that way had it in past
* Wasn't cleaning up raw test results so the reporting was counting it twice.
* More clean up tasks to avoid duplicates
* Another debug task added
* Reduce test matrix for debugging ... add a generic clean up
* Removed history part to help with debugging
* Updated Tsavorite tests to work with ALlure
* Should be last of Tsavorite test changes
* Changing back to full run. Updated Garnet.tests to work with Allure.
* First try at seeing if the CI can pick up if a test is not wired for Allure. By this check, found a few tests that haven't been wired properly, so fixed those.
* Fixed a bug in the path in ci
* Another try at CI check for Allure
* Failing on .net90 because tries to load them
* Bug in Tsav on net90 Ubuntu
* Removed Allure wiring on one cluster, tsav and garnet test to make sure it is working.
* Hopefully fixed duplicate entry issue in Allure
* Added Allure base class back on some tests
* Another try at fixing duplicates
* Added history back in
* Added what is required for all unit tests to be allure enabled
* Trying if putting AllureUnit fixture on baseclass is enough instead of putting it on every test
* formatting error
* Putting back the try and keep way it is
* Fixed Tsav tests that wasn't configured for Allure properly. Removed all the debug code too.
* Removed a file that is no longer used
* Fixes to what CoPilot said needed to change
* Changes to fix PR review Comments
* A few fixes from CoPilot review
* Cleaned up error handling
* add task manager implementation * Add test for replica to stop background collect task * add calls to resume suspend maintenance tasks * separate primary only from generic background tasks * misc fixes * fix formatting * loggerFactory null check * simplify task manager implementation * addressing comments * no allocation lookup placement category * add verbose log message * update RegisterAndRun * pass global cts in when waiting for task manager tasks to complete * check if TaskManager disposed before using global cts * add TaskManager tests * fix test * addressing comments and adding more tests * add test cleanup with exception * bump version * add Allure tests for task manager
* Add post-operation hooks and epoch-safe AOF logging * Introduce PostUpsertOperation, PostRMWOperation, and PostDeleteOperation hooks to ISessionFunctions, enabling actions after upsert, RMW, and delete but before record unlock. * Add IEpochAccessor interface for epoch management by Post*Operation hooks. * Refactor TsavoriteLog.Enqueue to accept an epoch accessor from caller layer, ensuring we correctly suspend/resume the outer epoch during blocking log appends. * Move AOF write logic in Garnet.server to post-operation hooks, using a UserData flag to defer logging until after the main operation (but before unlocking). * Make UpsertInfo, RMWInfo, and DeleteInfo carry a UserData byte for operation flags. * Update existing ISessionFunctions implementations with no-op post-operation hooks. * Enums UpsertAction, RMWAction, and DeleteAction are now byte-sized. These changes ensure that if we block waiting for AllocateBlock during AOF logging in Tsavorite, we will not be holding the outer (TsavoriteKV-level) epoch, thereby preventing a epoch table full situation for other normal operation (GET/SET) threads. * format, update version * fix bug * fixes * nits * use constant for NeedAofLog
… putting allure files in website folders (#1511) * Added Allure to deploy website. * Added download artifacts to deploy * Missing the wrokflow * Make it so deploy works on pass or fail * Typo * Testing the deploy by setting darrenge/AllureFix as valid branch ... remove after testing works. * Fix nightly to continue on error ... also for debugging reducing matrix to one test * Just minor changes to see if helps both modified * Remove debug code * Minor formatting * Added comments regarding the source of the Allure data and fixed a bug where allure data wasn't fully copied * CoPilot PR Review comments - Extra error handling so web deploy doesn't fail for non Nightly runs. Fixed path bug too. * CoPilot Review: Just comments and spacing issues * CoPilo PR Review: cleaned up the check out by removing sparse-checkout part
…the front page. (#1512)
* To access other artifacts, need run id and token ... so added that * CoPilot Review: Removed blank line and removed trailing spaces
* Confirmed download worked and fixed bug in copy and enabled Allure button. * Put in debug step so can test on private branch * Added debug code * Switch back to main so should be good to go. * Cleaned up the path
…Allure part of the website is wiped out until next nightly is ran. This fix keeps Allure site untouched when BDN is ran (#1517)
* replace net9 with net10 in project files * Update net9.0 to net10.0 in ci and nightly * Updated BDN to run net10 instead of net90 the website is not done yet. * Updating BDNs to not use .net9.0. Unfortunately, .net10 is not supported in current BDNs. * Updated External Release to release 8.0 and 10.0 only (no 9.0) * fix * Enabled Win10 for BDN since recent fix * Updated a couple BDNs expected values that were a bit out of range * Updated .net9.0 for CodeQL --------- Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
* Bugfix in SortedSetObject * Fixed in HashObject as well
Bumps [@easyops-cn/docusaurus-search-local](https://github.com/easyops-cn/docusaurus-search-local/tree/HEAD/packages/docusaurus-search-local) from 0.52.1 to 0.52.3. - [Release notes](https://github.com/easyops-cn/docusaurus-search-local/releases) - [Commits](https://github.com/easyops-cn/docusaurus-search-local/commits/v0.52.3/packages/docusaurus-search-local) --- updated-dependencies: - dependency-name: "@easyops-cn/docusaurus-search-local" dependency-version: 0.52.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion (#1532) * When hundreds of threads compete for epoch table entries, the previous spin-wait loop in ReserveEntry caused 100% CPU utilization due to tight spinning with Thread.Yield(). Changes: - Add SemaphoreSlim-based wait mechanism for threads when epoch table is full - Split ReserveEntry into fast path (TryAcquireEntry) and slow path (ReserveEntryWait) - Fast path: probes startOffset1, startOffset2, then circles table twice - fully inlinable - Slow path: uses try/finally with semaphore wait - marked NoInlining since kernel wait dominates cost anyway - Release() signals one waiting thread via volatile waiterCount check (nearly zero overhead when no waiters) - Double-check pattern in ReserveEntryWait prevents lost wakeups: increment waiterCount, re-check for slots, then wait - SemaphoreSlim uses Monitor.Pulse internally which provides FIFO wake-up order, preventing starvation Performance characteristics: - No contention: unchanged - fast path acquires entry with same probing logic - Table full: threads wait efficiently instead of burning CPU - Release hot path: single volatile read of waiterCount when no waiters
--- updated-dependencies: - dependency-name: KeraLua dependency-version: 1.4.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1527) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* Bump react from 19.1.1 to 19.2.4 in /website Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 19.1.1 to 19.2.4. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.4/packages/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fixing package update discrepency * Updating yarn.lock --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* Bump Azure.Storage.Blobs from 12.26.0 to 12.27.0 --- updated-dependencies: - dependency-name: Azure.Storage.Blobs dependency-version: 12.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Removing hard-coded project references * Fixing breaking API changes in Azure.Storage.Blobs * Adding --skipApiVersionCheck when running Azurite --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
) * Bump Microsoft.Extensions.Configuration.Json from 9.0.9 to 10.0.2 --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.Json dependency-version: 10.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fixing package discrepency --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
--- updated-dependencies: - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* replace net9 with net10 in project files * perfs * updates * prep for PR * nit --------- Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
* Initial plan * Bump version to 1.0.96 Co-authored-by: TalZaccai <18443527+TalZaccai@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TalZaccai <18443527+TalZaccai@users.noreply.github.com>
* Initial plan * Fix NuGet package to include net10.0 files instead of net9.0 Co-authored-by: badrishc <18355833+badrishc@users.noreply.github.com> * Bump version to 1.0.97 for new release with NuGet fix Co-authored-by: badrishc <18355833+badrishc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: badrishc <18355833+badrishc@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.101.1 to 5.105.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.101.1...v5.105.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.105.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs main into dev, bringing in a broad set of infrastructure and feature updates including the .NET 10 transition, Allure test reporting enablement, cluster endpoint selection enhancements, and Tsavorite post-operation callback plumbing.
Changes:
- Update repo-wide target frameworks and documentation/CI from
net9.0tonet10.0, including benchmark and packaging updates. - Integrate Allure reporting across test projects (new
AllureTestBase, Allure packages, Allure report assets + website deploy flow). - Add cluster “preferred endpoint type” + “announce hostname” support and adjust cluster slot/redirect logic and tests; extend Tsavorite session callbacks to add
Post*Operationhooks with epoch access.
Reviewed changes
Copilot reviewed 247 out of 248 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| website/package.json | Bump website dependencies (search-local, React) and add override. |
| website/docs/getting-started/build.md | Update build/test/run docs to net10.0. |
| website/docs/dev/onboarding.md | Update onboarding commands to net10.0 and document Allure testing requirements. |
| test/Garnet.test/UnixSocketTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/TransactionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/TestUtils.cs | Extend server options helper parameters (cluster endpoint/announce + expiration collection frequency). |
| test/Garnet.test/ScratchBufferAllocatorTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespTransactionProcTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespTlsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespSortedSetTests.cs | Add Allure attributes/base class and add ZEXPIRE + remove regression test. |
| test/Garnet.test/RespSortedSetGeoTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespSortedSetGarnetClientTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespSlowLogTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespSetTest.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespScanCommandsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespRevivificationTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespPubSubTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespModuleTests.cs | Add Allure attributes/base class (including nested fixture). |
| test/Garnet.test/RespMetricsTest.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespLowMemoryTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespListTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespListGarnetClientTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespInfoTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespHashTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespGetLowMemoryTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespEtagTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespCustomCommandTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespConfigTests.cs | Add Allure attributes/base class for multiple fixtures. |
| test/Garnet.test/RespCommandTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespBlockingCollectionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespAofTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespAofAzureTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/RespAdminCommandsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Resp/RespReadUtilsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Resp/RespParseFuzzRegressionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Resp/GarnetAuthenticatorTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Resp/ACL/SetUserTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/RespCommandTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Resp/ACL/ParallelTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/GetUserTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/DeleteUserTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/BasicTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/AclTest.cs | Make ACL base test derive from AllureTestBase. |
| test/Garnet.test/Resp/ACL/AclParserTests.cs | Add Allure attributes. |
| test/Garnet.test/Resp/ACL/AclConfigurationFileTests.cs | Add Allure attributes. |
| test/Garnet.test/ReadCacheTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/ObjectTestsForOutput.cs | Add Allure attributes/base class and minor whitespace cleanup. |
| test/Garnet.test/NetworkTests.cs | Add Allure attributes/base class (DEBUG-only tests). |
| test/Garnet.test/MultiDatabaseTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/LuaScriptTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/LuaScriptRunnerTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/IndexGrowthTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/HyperLogLogTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GeoHashTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetServerConfigTests.cs | Add Allure attributes/base class and add CLI parsing tests for cluster endpoint options. |
| test/Garnet.test/GarnetObjectTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetJSON/JsonCommandsTest.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetJSON/JSONPath/QueryExpressionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetJSON/JSONPath/JsonPathRegressionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetJSON/JSONPath/JsonPathParseTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetJSON/JSONPath/JsonPathExecuteTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetClientTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/GarnetBitmapTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/Garnet.test.csproj | Add Allure package refs and disable AspectInjector. |
| test/Garnet.test/FuzzTargetTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/ExpiredKeyDeletionTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/DocsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/CacheSizeTrackerTests.cs | Add Allure attributes/base class. |
| test/Garnet.test/AllureTestBase.cs | New Allure base class to label environment/suites for reporting. |
| test/Garnet.test.cluster/ReplicationTests/ClusterResetDuringReplicationTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/RedirectTests/ClusterSlotVerificationTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/Garnet.test.cluster.csproj | Add Allure packages and link AllureTestBase. |
| test/Garnet.test.cluster/ClusterTestUtils.cs | Update cluster slots parsing and endpoint resolution logic. |
| test/Garnet.test.cluster/ClusterTestContext.cs | Thread through new server options into cluster instance creation. |
| test/Garnet.test.cluster/ClusterNegativeTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/ClusterMigrateTests.cs | Add Allure attributes/base class and extend cases for endpoint preference/hostname. |
| test/Garnet.test.cluster/ClusterMigrateTLSTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/ClusterManagementTests.cs | Expand test matrix for preferred endpoint type/announce hostname and validate metadata. |
| test/Garnet.test.cluster/ClusterConfigTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/ClusterAuthCommsTests.cs | Add Allure attributes/base class. |
| test/Garnet.test.cluster/ClusterAadAuthTests.cs | Add Allure attributes/base class. |
| test/BDNPerfTests/run_bdnperftest.ps1 | Update example framework parameter. |
| test/BDNPerfTests/BDN_Benchmark_Config.json | Update comments and expected allocation thresholds. |
| test/Allure/categories.json | Add Allure category configuration for report grouping. |
| test/Allure/GenerateAllureReport.ps1 | Add script to generate Allure report from combined results + history. |
| playground/TstRunner/TstRunner.csproj | Add Allure packages. |
| playground/SampleModule/SampleModule.csproj | Remove explicit TFM (inherit repo TargetFrameworks). |
| playground/MigrateBench/MigrateBench.csproj | Remove explicit TFM (inherit repo TargetFrameworks). |
| playground/CommandInfoUpdater/CommandInfoUpdater.csproj | Remove explicit TFM (inherit repo TargetFrameworks). |
| modules/NoOpModule/NoOpModule.csproj | Remove Azure.Storage.Blobs override (use central package version). |
| modules/GarnetJSON/GarnetJSON.csproj | Remove Azure.Storage.Blobs override (use central package version). |
| main/GarnetServer/Properties/PublishProfiles/win-x64-based-readytorun.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/win-arm64-based-readytorun.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/portable.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/osx-x64-based.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/osx-arm64-based.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/linux-x64-based.pubxml | Update publish profiles to net10.0 and remove BOM. |
| main/GarnetServer/Properties/PublishProfiles/linux-arm64-based.pubxml | Update publish profiles to net10.0 and remove BOM. |
| libs/storage/Tsavorite/cs/test/WaitForCommit.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/UnsafeContextTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/Tsavorite.test.csproj | Add Allure packages and link AllureTestBase. |
| libs/storage/Tsavorite/cs/test/TryEnqueueBasicTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/TransactionalUnsafeContextTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/StateMachineDriverTests.cs | Add Allure base class/attributes to state-machine tests. |
| libs/storage/Tsavorite/cs/test/SpanByteVLVectorTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SpanByteTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SpanByteLogScanTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SpanByteLogCompactionTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SpanByteIterationTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SimpleVersionSchemeTest.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SimpleTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SimpleRecoveryTest.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SharedDirectoryTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/SessionTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/RevivificationTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/RecoveryTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/RecoveryCheckTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/RecoverReadOnlyTest.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ReadCacheChainTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ReadAddressTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/RandomReadCacheTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/PostOperationsTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/OverflowBucketLockTableTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectRecoveryTest3.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectRecoveryTest2.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectRecoveryTest.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectReadCacheTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectLogScanTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectLogCompactionTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectIterationTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectInlineTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectIdMapTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ObjectDiskDeleteTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/NeedCopyUpdateTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/NativeReadCacheTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/MoreLogCompactionTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ModifiedBitTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/MiscTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ManagedLocalStorageTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/MallocFixedPageSizeTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LowMemoryTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogTests.cs | Add Allure attributes/base class to Tsavorite log tests. |
| libs/storage/Tsavorite/cs/test/LogShiftTailStressTest.cs | Add Allure attributes. |
| libs/storage/Tsavorite/cs/test/LogScanTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogResumeTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogRecoverReadOnlyTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogRecordTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogReadAsyncTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LogFastCommitTests.cs | Add Allure attributes. |
| libs/storage/Tsavorite/cs/test/LogAndDeviceConfigTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/LargeObjectTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/InsertAtTailSpanByteStressTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/InputOutputParameterTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/FunctionPerSessionTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/FlakyDeviceTests.cs | Add Allure attributes. |
| libs/storage/Tsavorite/cs/test/ExpirationTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/EnqueueTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/EnqueueAndWaitForCommit.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/DeviceTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/DeviceLogTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/DeltaLogTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ConcurrentCounterTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/ComponentRecoveryTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/CompletePendingTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/CheckpointManagerTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/CancellationTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/BasicTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/BasicStorageTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/test/BasicLockTests.cs | Add Allure attributes/base class to Tsavorite tests. |
| libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/BlobUtilsV12.cs | Update blob listing calls to use options-based GetBlobs APIs. |
| libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs | Update blob listing and add required models import. |
| libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs | Update async blob enumeration to use options-based API. |
| libs/storage/Tsavorite/cs/src/core/VarLen/SpanByteFunctions.cs | Relax memoryPool field accessibility. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/UpsertValueSelector.cs | Add PostUpsertOperation dispatch across selector variants. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalUpsert.cs | Add post-upsert callback and refactor UpsertInfo construction. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs | Add post-RMW callback and refactor RMWInfo construction. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalDelete.cs | Add post-delete callback and refactor DeleteInfo construction. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/ContinuePending.cs | Add post-RMW callback path for pending RMW completion. |
| libs/storage/Tsavorite/cs/src/core/Index/Interfaces/SessionFunctionsBase.cs | Add default no-op Post*Operation hooks. |
| libs/storage/Tsavorite/cs/src/core/Index/Interfaces/ISessionFunctionsWrapper.cs | Add wrapper interface for Post*Operation hooks. |
| libs/storage/Tsavorite/cs/src/core/Index/Interfaces/ISessionFunctions.cs | Add new PostUpsertOperation/PostRMWOperation/PostDeleteOperation APIs. |
| libs/storage/Tsavorite/cs/src/core/Index/Interfaces/CallbackInfos.cs | Add UserData byte to Upsert/RMW/Delete info structs. |
| libs/storage/Tsavorite/cs/src/core/Epochs/LightEpoch.cs | Introduce IEpochAccessor and add ReleaseIfHeld helper. |
| libs/storage/Tsavorite/cs/src/core/ClientSession/SessionFunctionsWrapper.cs | Forward Post*Operation calls to session functions. |
| libs/storage/Tsavorite/cs/src/core/ClientSession/NoOpSessionFunctions.cs | Implement new Post*Operation methods as no-ops. |
| libs/storage/Tsavorite/cs/src/core/Allocator/AllocatorBase.cs | Add clarifying comments on retry codes. |
| libs/storage/Tsavorite/cs/benchmark/YCSB.benchmark/SessionFixedLenFunctions.cs | Implement new Post*Operation methods as no-ops. |
| libs/server/TaskManager/TaskType.cs | Add TaskType enum + mapping extensions for placement categories. |
| libs/server/TaskManager/TaskPlacementCategory.cs | Add task placement flags enum. |
| libs/server/TaskManager/TaskMetadata.cs | Add task metadata container (CTS + Task). |
| libs/server/Storage/Functions/UnifiedStore/UnifiedSessionFunctions.cs | Add UserData flag constant and remove unsafe qualifier. |
| libs/server/Storage/Functions/UnifiedStore/RMWMethods.cs | Defer AOF logging to PostRMWOperation via UserData. |
| libs/server/Storage/Functions/UnifiedStore/PrivateMethods.cs | Thread epoch accessor into AOF enqueue calls. |
| libs/server/Storage/Functions/UnifiedStore/DeleteMethods.cs | Defer AOF delete logging to PostDeleteOperation via UserData. |
| libs/server/Storage/Functions/ObjectStore/RMWMethods.cs | Defer AOF logging to PostRMWOperation via UserData. |
| libs/server/Storage/Functions/ObjectStore/PrivateMethods.cs | Thread epoch accessor into AOF enqueue calls; simplify incorrect-type helper signature. |
| libs/server/Storage/Functions/ObjectStore/ObjectSessionFunctions.cs | Add UserData flag constant and remove unsafe qualifier. |
| libs/server/Storage/Functions/ObjectStore/DeleteMethods.cs | Defer AOF delete logging to PostDeleteOperation via UserData. |
| libs/server/Storage/Functions/MainStore/UpsertMethods.cs | Defer AOF upsert logging to PostUpsertOperation via UserData. |
| libs/server/Storage/Functions/MainStore/RMWMethods.cs | Defer AOF RMW logging to PostRMWOperation via UserData. |
| libs/server/Storage/Functions/MainStore/PrivateMethods.cs | Thread epoch accessor into AOF enqueue calls. |
| libs/server/Storage/Functions/MainStore/MainSessionFunctions.cs | Add UserData flag constant. |
| libs/server/Storage/Functions/MainStore/DeleteMethods.cs | Defer AOF delete logging to PostDeleteOperation via UserData. |
| libs/server/Storage/Functions/MainStore/CallbackMethods.cs | Remove unsafe qualifier from partial struct declaration. |
| libs/server/Servers/ServerOptions.cs | Add announce hostname + preferred endpoint type to server options. |
| libs/server/Resp/RespServerSessionSlotVerify.cs | Add CanServeSlot comment/clarification. |
| libs/server/Objects/SortedSet/SortedSetObject.cs | Fix heap size accounting constant used for PQ entries. |
| libs/server/Objects/Hash/HashObject.cs | Fix heap size accounting constant used for PQ entries. |
| libs/server/Databases/MultiDatabaseManager.cs | Minor whitespace cleanup. |
| libs/server/Cluster/ClusterPreferredEndpointType.cs | New enum defining endpoint preference for cluster redirects/slots. |
| libs/host/defaults.conf | Add defaults for cluster announce hostname and preferred endpoint type. |
| libs/host/Garnet.host.csproj | Update packaged TFMs to net10.0. |
| libs/host/Configuration/Options.cs | Add CLI options for announce hostname and preferred endpoint type. |
| libs/cluster/Session/SlotVerification/RespClusterSlotVerify.cs | Use preferred endpoint type in MOVED/ASK messages. |
| libs/cluster/Session/RespClusterSlotManagementCommands.cs | Use preferred endpoint type for CLUSTER SLOTS output. |
| libs/cluster/Session/ReplicaOfCommand.cs | Start primary-only background tasks after REPLICAOF promotes to primary. |
| libs/cluster/Server/Replication/ReplicaOps/ReplicaReceiveCheckpoint.cs | Suspend primary-only tasks during replication attach to protect AOF. |
| libs/cluster/Server/Replication/ReplicaOps/ReplicaDisklessSync.cs | Null-check session bump; suspend tasks during replication; fix error return path. |
| libs/cluster/Server/Failover/ReplicaFailoverSession.cs | Start primary-only background tasks after failover takeover. |
| libs/cluster/Server/ClusterManagerWorkerState.cs | Use cluster announce hostname on reset. |
| libs/cluster/Server/ClusterManager.cs | Use cluster announce hostname (or fallback) when initializing local worker. |
| libs/cluster/CmdStrings.cs | Add RESP null constant + string form used in cluster slots formatting. |
| benchmark/BDN.benchmark/Program.cs | Update BDN job setup from net9 to net10. |
| README.md | Add Allure report link badge. |
| Directory.Packages.props | Add Allure packages; bump Azure.Storage.Blobs, KeraLua, and several Microsoft.Extensions/System.Text.Json versions. |
| Directory.Build.props | Update global TargetFrameworks to net8.0;net10.0. |
| .github/workflows/deploy-website.yml | Extend website deploy to include Allure report publishing with history preservation. |
| .github/workflows/codeql.yml | Update build TFMs and comments to net10.0. |
| .github/workflows/ci-bdnbenchmark.yml | Update benchmark matrix TFMs to net10.0. |
| .azure/pipelines/azure-pipelines.yml | Update pipelines to use .NET 10 instead of .NET 9. |
| .azure/pipelines/azure-pipelines-nightly.yml | Update nightly pipelines to net10 naming/TFM. |
| .azure/pipelines/azure-pipelines-external-release.yml | Update artifact description to net10.0. |
Comments suppressed due to low confidence (1)
libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:107
- This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TalZaccai
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last 'main' changes were perf modifications for v2 comparison and Post(UMD)Operation