refactor(scripts): extract Invoke-PackageExtension for testability

[WilliamBerryiii]

Description

Extracted the main packaging logic from Package-Extension.ps1 into a testable Invoke-PackageExtension orchestrator function with explicit path parameters. The main execution block is now a thin wrapper that delegates to this function, enabling comprehensive unit testing of the packaging workflow.

• Introduced Invoke-PackageExtension orchestrator with ExtensionDirectory, RepoRoot, Version, DevPatchNumber, ChangelogPath, and PreRelease parameters
• Refactored main execution to call the new function, eliminating script-level variable scope issues
• Added 8 new Pester tests covering error handling paths: invalid directories, missing package.json, invalid JSON, manifest validation failures, and version format validation
• Increased test coverage from baseline to 78.4% for Package-Extension.ps1

Related Issue(s)

Fixes #263

Type of Change

Select all that apply:

Code & Documentation:

• Bug fix (non-breaking change fixing an issue)
• New feature (non-breaking change adding functionality)
• Breaking change (fix or feature causing existing functionality to change)
• Documentation update

Infrastructure & Configuration:

• GitHub Actions workflow
• Linting configuration (markdown, PowerShell, etc.)
• Security configuration
• DevContainer configuration
• Dependency update

AI Artifacts:

• Reviewed contribution with prompt-builder agent and addressed all feedback
• Copilot instructions (.github/instructions/*.instructions.md)
• Copilot prompt (.github/prompts/*.prompt.md)
• Copilot agent (.github/agents/*.agent.md)

Other:

• Script/automation (.ps1, .sh, .py)
• Other (please describe):

Sample Prompts (for AI Artifact Contributions)

N/A - This PR contains script changes only.

Testing

• Ran full Pester test suite: 640+ tests pass, 0 failures
• Verified Package-Extension.ps1 coverage at 78.4% (149 covered, 41 missed lines)
• Remaining uncovered lines are orchestrator integration paths and main execution guard

Checklist

Required Checks

• Documentation is updated (if applicable)
• Files follow existing naming conventions
• Changes are backwards compatible (if applicable)
• Tests added for new functionality (if applicable)

AI Artifact Contributions

N/A

Required Automated Checks

The following validation commands must pass before merging:

• Markdown linting: npm run lint:md
• Spell checking: npm run spell-check
• Frontmatter validation: npm run lint:frontmatter
• Link validation: npm run lint:md-links
• PowerShell analysis: npm run lint:ps

Security Considerations

• This PR does not contain any sensitive or NDA information
• Any new dependencies have been reviewed for security issues
• Security-related scripts follow the principle of least privilege

Additional Notes

The Invoke-PackageExtension function returns a structured hashtable with Success, OutputPath, Version, and ErrorMessage properties, providing consistent error handling for CI/CD integration.

🔧 - Generated by Copilot

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull request overview

Refactors the VS Code extension packaging script to extract the entry-point workflow into a testable Invoke-PackageExtension function and expands Pester coverage for packaging error paths.

Changes:

• Added Invoke-PackageExtension orchestrator that performs path validation, manifest/version resolution, packaging invocation, and cleanup.
• Refactored the script entry point to delegate to Invoke-PackageExtension and return structured results.
• Expanded Pester tests for vsce discovery, manifest validation, version validation, and orchestrator error handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
scripts/extension/Package-Extension.ps1	Extracts orchestration into Invoke-PackageExtension, updates vsce invocation, and adds standardized result returns/cleanup.
scripts/tests/extension/Package-Extension.Tests.ps1	Adds new Pester cases for vsce discovery and multiple orchestrator/validation error paths.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 73.68421% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.25%. Comparing base (d58541c) to head (ed20404).

Files with missing lines	Patch %	Lines
scripts/extension/Package-Extension.ps1	73.68%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   44.26%   48.25%   +3.98%     
==========================================
  Files          15       15              
  Lines        2826     2810      -16     
==========================================
+ Hits         1251     1356     +105     
+ Misses       1575     1454     -121     

Flag	Coverage Δ
pester	48.25% <73.68%> (+3.98%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
scripts/extension/Package-Extension.ps1	83.85% <73.68%> (+57.41%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.