Move protocol implementation into new package#81
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Contributor
Author
|
This PR is related to #50. Move it to a new package, but still keep it in core.jar. |
Member
|
Let's release this in 0.3.0. |
yaohaizh
suggested changes
Oct 23, 2017
| this.terminateSession = true; | ||
| } | ||
|
|
||
| public boolean isTerminating() { |
Contributor
There was a problem hiding this comment.
Quite curious about the different about
isTerminating and "terminateSession```
Contributor
Author
There was a problem hiding this comment.
duplicate. Remove isTerminating method.
| String header = String.format("Content-Length: %d%s", jsonBytes.length, TWO_CRLF); | ||
| byte[] headerBytes = header.getBytes(PROTOCOL_ENCODING); | ||
|
|
||
| byte[] data = new byte[headerBytes.length + jsonBytes.length]; |
Contributor
There was a problem hiding this comment.
Sounds some duplication? Should be ByteBuffer?
Contributor
Author
There was a problem hiding this comment.
Nice catch. fixed.
yaohaizh
previously approved these changes
Nov 2, 2017
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
yaohaizh
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com