Skip to content

chore(set-react-version): remove stale resolutions#1827

Merged
tido64 merged 1 commit intotrunkfrom
tido/fix-set-react-version
Feb 8, 2024
Merged

chore(set-react-version): remove stale resolutions#1827
tido64 merged 1 commit intotrunkfrom
tido/fix-set-react-version

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Feb 8, 2024

Description

Nightlies have been failing because it's trying to use @react-native/babel-preset 0.73 instead of nightly:

error node_modules/react-native/src/private/specs/components/DebuggingOverlayNativeComponent.js: /~/node_modules/react-native/src/private/specs/components/DebuggingOverlayNativeComponent.js: Unsupported param type for method "highlightTraceUpdates", param "updates". Found $ReadOnlyArray.
Error: /~/node_modules/react-native/src/private/specs/components/DebuggingOverlayNativeComponent.js: Unsupported param type for method "highlightTraceUpdates", param "updates". Found $ReadOnlyArray

Build log: https://github.com/microsoft/react-native-test-app/actions/runs/7824683491

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Run:

npm run set-react-version nightly

Verify that React Native related resolutions are removed from package.json:

     "@expo/json-file/@babel/code-frame": "^7.10.4",
     "@microsoft/eslint-plugin-sdl/eslint-plugin-react": "^7.33.0",
     "@pnpm/network.ca-file/graceful-fs": "~4.2.10",
-    "@react-native-community/cli": "^12.3.0",
-    "@react-native-community/cli-platform-android": "^12.3.0",
-    "@react-native-community/cli-platform-ios": "^12.3.0",
-    "@react-native/babel-preset": "^0.73.0",
-    "@react-native/community-cli-plugin/@react-native-community/cli-server-api": "^12.3.0",
-    "@react-native/community-cli-plugin/@react-native-community/cli-tools": "^12.3.0",
     "@semantic-release/npm/npm": "link:./example",
     "appium/@types/semver": "^7.5.6",
     "appium/yaml": "^2.3.4",

Verify that we are able to bundle:

cd example
yarn build:ios

@tido64 tido64 requested a review from kelset as a code owner February 8, 2024 08:20
@kelset
Copy link
Copy Markdown
Contributor

kelset commented Feb 8, 2024

changes LGTM but there's an hard crash iOS side; it's probably unrelated to this but I'll hold ✅ until we understand better what's happening.

Copy link
Copy Markdown
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested together with #1829 I was able to verify that the fixes work 👍

Simulator Screenshot - iPhone 15 - 2024-02-08 at 15 14 33

@tido64 tido64 merged commit 1d441c0 into trunk Feb 8, 2024
@tido64 tido64 deleted the tido/fix-set-react-version branch February 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants