chore(set-react-version): remove stale resolutions#1827
Merged
Conversation
Contributor
|
changes LGTM but there's an hard crash iOS side; it's probably unrelated to this but I'll hold ✅ until we understand better what's happening. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Nightlies have been failing because it's trying to use
@react-native/babel-preset0.73 instead of nightly:Build log: https://github.com/microsoft/react-native-test-app/actions/runs/7824683491
Platforms affected
Test plan
Run:
Verify that React Native related resolutions are removed from
package.json:"@expo/json-file/@babel/code-frame": "^7.10.4", "@microsoft/eslint-plugin-sdl/eslint-plugin-react": "^7.33.0", "@pnpm/network.ca-file/graceful-fs": "~4.2.10", - "@react-native-community/cli": "^12.3.0", - "@react-native-community/cli-platform-android": "^12.3.0", - "@react-native-community/cli-platform-ios": "^12.3.0", - "@react-native/babel-preset": "^0.73.0", - "@react-native/community-cli-plugin/@react-native-community/cli-server-api": "^12.3.0", - "@react-native/community-cli-plugin/@react-native-community/cli-tools": "^12.3.0", "@semantic-release/npm/npm": "link:./example", "appium/@types/semver": "^7.5.6", "appium/yaml": "^2.3.4",Verify that we are able to bundle: