-
Notifications
You must be signed in to change notification settings - Fork 98
fix: support more extensions when looking for react-native.config.*
#2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81a9347 to
6da53c5
Compare
szymonrybczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 Really interesting!
The thing is that if someone will call configureProjects function not directly in react-native.config.* file but through some helper in other file the value inside stacktrace will be wrong, but there's always fallback to default search.
Hmm... we should probably allow passing in the project root to avoid searching altogether. If we search the whole stack, we could end up in weird places outside the project. None of the alternatives are robust. |
|
@tido64 you can also leverage |
I believe that would cause a loop. |
Description
Support more extensions when looking for
react-native.config.*See also #2429
Platforms affected
Test plan
n/a