fix: add support for react-native-windows 0.64#296
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tido64
force-pushed
the
tido/support-rnw-64
branch
3 times, most recently
from
918f113 to
bbd31bb
Compare
tido64
force-pushed
the
tido/support-rnw-64
branch
from
bbd31bb to
30ec7f8
Compare
tom-un
approved these changes
Mar 30, 2021
| "react": "16.13.1", | ||
| "react-native": "0.63.4", | ||
| "react-native-macos": "0.63.3", | ||
| "react-native-macos": "0.63.23", |
Contributor
There was a problem hiding this comment.
Was there a reason to update the react-native-macos version with this change?
Member
Author
There was a problem hiding this comment.
No, I was mostly making sure that latest 0.63 still works.
| // @ts-ignore intentional use of unsupported platform | ||
| const params = mockParams({ platforms: ["nextstep"], flatten: true }); | ||
| expect(() => reactNativeConfig(params)).toThrowError( | ||
| expect(() => reactNativeConfig(params)).toThrow( |
Contributor
There was a problem hiding this comment.
Was toThrowError just an alias of toThrow?
Member
Author
There was a problem hiding this comment.
toThrowError is apparently an old, deprecated name. It showed up under build annotations:
|
🎉 This PR is included in version 0.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
react-native-windows0.64.Platforms affected
Test plan
react-native-windows0.64