fix community JSC support #3845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix compile error in ReactNativeHost.mm when Hermes is not being used. `fatal error: 'ReactCommon/RCTHermesInstance.h' file not found` the USE_HERMES preprocessor definition was only being set in GCC_PREPROCESSOR_DEFINITIONS (for C and Objective-C files), but NOT in OTHER_CPLUSPLUSFLAGS (for [Objective] C++) files. this caused ReactNativeHost.mm to NOT received the USE_HERMES=0 flag, making it incorrectly import Hermes symbols that aren't resolved at link time.
matthargett
requested review from
JasonVMo,
Saadnajmi,
acoates-ms and
tido64
as code owners
try to avoid a rapid follow up PR for v8, and make things a little more congruent
another conditional compile restoration. verified this works in my local branch of benchmark-test-app with RN 0.82 and @rnc/javascriptcore
tido64
reviewed
Nov 6, 2025
Member
tido64
left a comment
tido64
left a comment
There was a problem hiding this comment.
Thanks! Can you run yarn change at repo root to add a change log entry?
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
tido64
reviewed
Nov 7, 2025
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Member
|
Superseded by #3854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix compile error in ReactNativeHost.mm when Hermes is not being used:
fatal error: 'ReactCommon/RCTHermesInstance.h' file not foundI found this while updating our @rebeckerspecialties/benchmark repository to React Native 0.82 for re-benchmarking Hermes V1 on real-world devices with real-world hot path workloads.
the USE_HERMES preprocessor definition was only being set in GCC_PREPROCESSOR_DEFINITIONS (for C and Objective-C files), but NOT in OTHER_CPLUSPLUSFLAGS (for [Objective] C++) files. this caused ReactNativeHost.mm to NOT received the USE_HERMES=0 flag, making it incorrectly import Hermes symbols that aren't resolved at link time.
Test plan
Integration tested with a local patch-package in
rebeckerspecialties/benchmarking-test-app#69
alongside the fix in facebook/react-native#54421