fix(react-native-host): fix community JSC support #3854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compile error in `ReactNativeHost.mm` when Hermes is not being used. `fatal error: 'ReactCommon/RCTHermesInstance.h' file not found` The `USE_HERMES` preprocessor definition was only being set in `GCC_PREPROCESSOR_DEFINITIONS` (for C and Objective-C files), but NOT in `CPP_PREPROCESSOR_DEFINITIONS` (for [Objective] C++) files. This caused `ReactNativeHost.mm` to NOT receive the `USE_HERMES=0` flag, making it incorrectly import Hermes symbols that aren't resolved at link time.
tido64
requested review from
JasonVMo,
Saadnajmi and
acoates-ms
as code owners
JasonVMo
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compile error in
ReactNativeHost.mmwhen Hermes is not being used.fatal error: 'ReactCommon/RCTHermesInstance.h' file not foundThe
USE_HERMESpreprocessor definition was only being set inGCC_PREPROCESSOR_DEFINITIONS(for C and Objective-C files), but NOT inCPP_PREPROCESSOR_DEFINITIONS(for [Objective] C++) files. This causedReactNativeHost.mmto NOT receive theUSE_HERMES=0flag, making it incorrectly import Hermes symbols that aren't resolved at link time.Supersedes #3845.
Test plan
See #3845.