TypeScript validation during Metro bundling#392
Merged
Conversation
- Separate Project methods into "find" and "open", allowing caller to decide on the appropriate error-handling logic. - Add filtering when validating Project files. Only include ts[x] unless checkJs is enabled. - Make cache methods return a true/false result, moving error-handling up and out to the caller (Project). - Stop converting to lowercase during path normalization. This confuses typescript.
… of react-native JS files. They aren't typesafe and fail the check.
…everything is rebuilt and retested.
tido64
reviewed
Jul 13, 2021
tido64
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
@rnx-kit/typescript-servivce, bringing the public API in line with what is needed for typechecking during Metro bundling. Internally, push error handling up/out to the caller, and fix path normalization.Add TypeScript validation to
@rnx-kit/cliduring Metro bundling.Fix build
cleancommand, to force a truly clean run of build/test.Contributes to #173.
Test plan
Manually observe success during bundling. Then introduce code in test-app which is known to cause TypeScript errors, and manually observe them on the Metro console.