Skip to content

Avoid stale AzDO retry failure annotations - #10456

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-green-test-step
Aug 5, 2026
Merged

Avoid stale AzDO retry failure annotations#10456
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-green-test-step

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • report retry-enabled acceptance-test Azure DevOps annotations as warnings
  • keep transient failures visible without leaving stale failed-test errors after a successful retry
  • preserve genuine final failures through the test process exit code and published TRX results

Root cause

--report-azdo emits an irreversible ##vso[task.logissue type=error] as soon as an attempt fails. The retry orchestrator can later recover the test, but Azure DevOps retains the initial error annotation even though the final retry summary, exit code, and Tests tab are green.

Validation

  • built Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj in Release
  • confirmed the evaluated command line contains --report-azdo-severity warning
  • completed three independent code-review passes with no actionable findings

Report intermediate acceptance-test failures as warnings so successful retries do not leave the test step marked with failed annotations. Final retry failures remain enforced by the process exit code and TRX publication.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e336030-19fa-4526-8bf3-aca348e24bdd
Copilot AI balanced review requested due to automatic review settings August 5, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Configures retry-enabled MTP acceptance tests to avoid stale Azure DevOps failure annotations.

Changes:

  • Emits Azure DevOps annotations as warnings.
  • Retains final failure signaling through exit codes and TRX results.
Show a summary per file
File Description
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj Adds warning severity for Azure DevOps reporting.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

Potential security threats were detected in the agent output.

Review the workflow run logs for details.

🧵 Parallel-safety audit — PR #10456

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. The only changed file is test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj, and its diff only adds a --report-azdo-severity warning CLI argument to TestingPlatformCommandLineArguments. This is not a .runsettings, testconfig.json, or assembly-attribute change and does not alter parallelization scope, workers, or resource locking for the project. No changed test methods, lifecycle members, or fixture code exist in this PR.

Nothing to flag for parallel-safety.

Re-run with /parallel-audit.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40 AIC · ⌖ 1.04 AIC · ⊞ 24.7K · [◷]( · )

@Evangelink
Evangelink enabled auto-merge (squash) August 5, 2026 15:17
@Evangelink
Evangelink merged commit 0ba963b into main Aug 5, 2026
40 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/fix-green-test-step branch August 5, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants