Address retry response file review feedback - #10997
Merged
Amaury Levé (Evangelink) merged 3 commits intoSep 3, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Levé (Evangelink)
September 3, 2026 10:55
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Key diagnostic, warning, and per-attempt cleanup behavior remains insufficiently verified.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 4
New issues introduced by this change (4)
| Severity | Finding |
|---|---|
 |
src/Platform/Microsoft.Testing.Extensions.Retry/RetryOrchestrator.cs — No test exercises this new warning branch. The builder test proves a quoted suffix stays inline,… |
|
src/Platform/Microsoft.Testing.Platform/CommandLine/ResponseFileHelper.cs — The added nested-file tests only exercise FileNotFoundException, so the changed nested… |
|
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/RetryFailedTestsTests.cs — This assertion runs only after the entire retry session, so it proves eventual cleanup but not the… |
|
test/UnitTests/Microsoft.Testing.Platform.UnitTests/CommandLine/ResponseFileHelperTests.cs — This test assumes a fixed relative path is absent. If sensitive-nested-path.rsp is left in the… |
What changed in this PR
Improves retry response-file diagnostics, regeneration, path management, and cleanup verification.
Changes:
- Reports nested response-file failures with redaction.
- Handles quoted prefixes and multiple response files during retries.
- Centralizes generated paths and cleans files after attempts.
| File | Description |
|---|---|
ResponseFileHelper.cs |
Tracks nested-file diagnostic paths. |
RetryArgumentsBuilder.cs |
Centralizes paths and refines quote handling. |
RetryOrchestrator.cs |
Warns on unsafe serialization and cleans files. |
InternalAPI.Unshipped.txt |
Tracks new internal helpers. |
ResponseFileHelperTests.cs |
Tests nested-path reporting and redaction. |
RetryArgumentsBuilderTests.cs |
Tests quoted prefixes and multiple files. |
RetryFailedTestsTests.cs |
Checks generated-file cleanup. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Levé (Evangelink)
September 3, 2026 11:47
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Nested redaction is lost below the first nested response-file level, potentially exposing a sensitive path.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
|
src/Platform/Microsoft.Testing.Platform/CommandLine/ResponseFileHelper.cs — Redaction is lost below the first nested level. For example, if an outer file contains… |
Issues resolved since last review (4)
| Severity | Finding |
|---|---|
|
test/UnitTests/Microsoft.Testing.Platform.UnitTests/CommandLine/ResponseFileHelperTests.cs — This test assumes a fixed relative path is absent. If sensitive-nested-path.rsp is left in the… View resolved comment |
|
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/RetryFailedTestsTests.cs — This assertion runs only after the entire retry session, so it proves eventual cleanup but not the… View resolved comment |
|
src/Platform/Microsoft.Testing.Platform/CommandLine/ResponseFileHelper.cs — The added nested-file tests only exercise FileNotFoundException, so the changed nested… View resolved comment |
|
src/Platform/Microsoft.Testing.Extensions.Retry/RetryOrchestrator.cs — No test exercises this new warning branch. The builder test proves a quoted suffix stays inline,… View resolved comment |
Amaury Levé (Evangelink)
enabled auto-merge (squash)
September 3, 2026 13:54
Amaury Levé (Evangelink)
added
the
state/needs-review
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Levé (Evangelink)
September 3, 2026 13:59
View session
Petr Pokorny (0101)
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation addresses the stated feedback with focused regression coverage and no unresolved issues.
Review tier: Balanced
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
src/Platform/Microsoft.Testing.Platform/CommandLine/ResponseFileHelper.cs — Redaction is lost below the first nested level. For example, if an outer file contains… View resolved comment |
Amaury Levé (Evangelink)
deleted the
dev/amauryleve/pr10963-followup-retry-response-files
branch
September 3, 2026 16:26
Amaury Levé (Evangelink)
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10963.
Addresses the remaining response-file review feedback: