Clarify no-op nature of duplicate test definition name update in TRX report engine

[Copilot]

The auto-reviewer flagged a potential inconsistency between uniqueTestDefinitionTestIds and the testDefinitions XElement when a second occurrence of a test ID provides an explicit TrxTestDefinitionName. The concern was that the dictionary update at lines 586-590 could diverge from the already-written XElement.

Analysis

The concern is not valid. When isExplicitlyProvided is true, the guard at line 580 already enforces name equality before reaching line 586:

// Lines 580-583: throws if either name is explicit AND names differ
if ((isExplicitlyProvided || existing.ExistingIsExplicitlyProvided) &&
    existing.ExistingTestDefinitionName != testDefinitionName)
{
    throw new InvalidOperationException(...);
}

// Lines 586-590: only reachable when names are guaranteed equal
if (!existing.ExistingIsExplicitlyProvided && isExplicitlyProvided)
{
    // testDefinitionName == existing.ExistingTestDefinitionName here — only flag changes
    uniqueTestDefinitionTestIds[id] = (testDefinitionName, true);
}

Since differing names trigger an exception at line 583, line 589 is only ever reached when the names are identical. The dictionary update is name-identical; the only mutation is flipping ExistingIsExplicitlyProvided from false to true. No XElement/dictionary name inconsistency is possible.

---

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.