Prefer setting TrxFullyQualifiedTypeNameProperty per TestMethodIdentifierProperty#7650
Merged
Evangelink merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VSTestBridge TestResult → MTP TestNode conversion so TRX className derivation prefers TestMethodIdentifierProperty (when present) over parsing TestCase.FullyQualifiedName, aligning TRX output with the upcoming NUnit TestMethodIdentifierProperty support.
Changes:
- Reads
TestMethodIdentifierPropertyfrom theTestNodeproperty bag when TRX is enabled. - Populates
TrxFullyQualifiedTypeNamePropertyfromTestMethodIdentifierProperty.Namespace+TypeName, falling back to parsingTestCase.FullyQualifiedNameonly when the identifier property is absent.
src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs
Show resolved
Hide resolved
Evangelink
approved these changes
Apr 1, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to nunit/nunit3-vs-adapter#1351
Once NUnit adds TestMethodIdentifierProperty, we want that to be used for
TrxFullyQualifiedTypeNameProperty.The alternative for this would be updating TRX extension to consider
TestMethodIdentifierPropertybefore it considers TrxFullyQualifiedTypeNameProperty altogether. Eventually, maybe we should deprecateTrxFullyQualifiedTypeNameProperty.