Skip to content

Prefer setting TrxFullyQualifiedTypeNameProperty per TestMethodIdentifierProperty #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Apr 1, 2026
+16 −4
Merged

Prefer setting TrxFullyQualifiedTypeNameProperty per TestMethodIdentifierProperty #7650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,23 @@ public static TestNode ToTestNode(

testNode.Properties.Add(new TrxTestDefinitionName(testResult.TestCase.DisplayName ?? testResult.TestCase.FullyQualifiedName));

// TODO: Consider retrieving TestMethodIdentifierProperty first (which could have been added through addAdditionalProperties.
// VSTest's TestCase.FQN is very non-standard.
// We should avoid using it if we can.
if (TryParseFullyQualifiedType(testResult.TestCase.FullyQualifiedName, out string? fullyQualifiedType))
TestMethodIdentifierProperty? testMethodIdentifierProperty = testNode.Properties.SingleOrDefault<TestMethodIdentifierProperty>();
if (testMethodIdentifierProperty is not null)
{
// TODO: Should TRX className have arity for generic classes?
if (RoslynString.IsNullOrEmpty(testMethodIdentifierProperty.Namespace))
{
testNode.Properties.Add(new TrxFullyQualifiedTypeNameProperty(testMethodIdentifierProperty.TypeName));
}
else
{
testNode.Properties.Add(new TrxFullyQualifiedTypeNameProperty($"{testMethodIdentifierProperty.Namespace}.{testMethodIdentifierProperty.TypeName}"));
}
}
else if (TryParseFullyQualifiedType(testResult.TestCase.FullyQualifiedName, out string? fullyQualifiedType))
{
// VSTest's TestCase.FQN is very non-standard.
// We should avoid using it if we can, and so we prefer TestMethodIdentifierProperty first.
testNode.Properties.Add(new TrxFullyQualifiedTypeNameProperty(fullyQualifiedType));
}
else
Expand Down
Loading