Skip to content

Remove most of CopilotRemoteAgentManager#8689

Merged
alexr00 merged 1 commit intomainfrom
alexr00/controversial-carp
Apr 22, 2026
Merged

Remove most of CopilotRemoteAgentManager#8689
alexr00 merged 1 commit intomainfrom
alexr00/controversial-carp

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Apr 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 22, 2026 10:08
@alexr00 alexr00 enabled auto-merge (squash) April 22, 2026 10:08
@alexr00 alexr00 self-assigned this Apr 22, 2026
@alexr00 alexr00 marked this pull request as draft April 22, 2026 10:08
auto-merge was automatically disabled April 22, 2026 10:08

Pull request was converted to draft

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR trims down CopilotRemoteAgentManager so it primarily acts as a thin container for wiring up Copilot PR watching, and removes now-unneeded test scaffolding.

Changes:

  • Removed most of the Copilot remote agent manager logic (availability/assignability/repo selection/Copilot API init), leaving watcher registration.
  • Cleaned up a test file by removing an unused CopilotRemoteAgentManager import and mock.
Show a summary per file
File Description
src/test/issues/issueTodoProvider.test.ts Removes unused Copilot manager test mock/import.
src/github/copilotRemoteAgent.ts Removes most CopilotRemoteAgentManager logic and related imports, retaining PR watcher wiring + SessionIdForPr.

Copilot's findings

Comments suppressed due to low confidence (1)

src/test/issues/issueTodoProvider.test.ts:12

  • This test file currently only patches issueUtil.isComment in before/after, but contains no it(...) test cases or assertions. That means it doesn’t actually verify any behavior and can be misleading (and may mask regressions if the setup starts throwing). Consider either adding at least one concrete test that exercises IssueTodoProvider behavior, or removing this file/setup entirely if it’s no longer needed.
describe('IssueTodoProvider', function () {
	// Mock isComment
	// We don't have a real 'vscode.TextDocument' in these tests, which
	// causes 'vscode.languages.getTokenInformationAtPosition' to throw.
  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread src/github/copilotRemoteAgent.ts
@alexr00 alexr00 marked this pull request as ready for review April 22, 2026 11:00
@alexr00 alexr00 enabled auto-merge (squash) April 22, 2026 11:00
@alexr00 alexr00 merged commit 8883813 into main Apr 22, 2026
10 checks passed
@alexr00 alexr00 deleted the alexr00/controversial-carp branch April 22, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants