Skip to content

Remove most of CopilotRemoteAgentManager #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Apr 22, 2026
+1 −124
Merged

Remove most of CopilotRemoteAgentManager #8689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 1 addition & 119 deletions src/github/copilotRemoteAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,15 @@
*--------------------------------------------------------------------------------------------*/

import * as vscode from 'vscode';
import { RepoInfo } from './common';
import { CopilotApi, getCopilotApi } from './copilotApi';
import { CopilotPRWatcher } from './copilotPrWatcher';

import { CredentialStore } from './credentials';
import { FolderRepositoryManager } from './folderRepositoryManager';
import { GitHubRepository } from './githubRepository';
import { RepositoriesManager } from './repositoriesManager';
import { CopilotRemoteAgentConfig } from '../common/config';
import { COPILOT_CLOUD_AGENT, COPILOT_LOGINS } from '../common/copilot';
import { COPILOT_CLOUD_AGENT } from '../common/copilot';
import { Disposable } from '../common/lifecycle';
import Logger from '../common/logger';
import { GitHubRemote } from '../common/remote';
import { ITelemetry } from '../common/telemetry';
import { PrsTreeModel } from '../view/prsTreeModel';

const PREFERRED_GITHUB_CODING_AGENT_REMOTE_WORKSPACE_KEY = 'PREFERRED_GITHUB_CODING_AGENT_REMOTE';

export namespace SessionIdForPr {

const prefix = 'pull-session-by-index';
Expand Down Expand Up @@ -59,113 +50,4 @@ export class CopilotRemoteAgentManager extends Disposable {

this._register(new CopilotPRWatcher(this.repositoriesManager, this.prsTreeModel));
}
Comment thread
alexr00 marked this conversation as resolved.
private _copilotApiPromise: Promise<CopilotApi | undefined> | undefined;
private get copilotApi(): Promise<CopilotApi | undefined> {
if (!this._copilotApiPromise) {
this._copilotApiPromise = this.initializeCopilotApi();
}
return this._copilotApiPromise;
}

private async initializeCopilotApi(): Promise<CopilotApi | undefined> {
return await getCopilotApi(this.credentialStore, this.telemetry);
}

async isAssignable(): Promise<boolean> {
const setCachedResult = (b: boolean) => {
this._isAssignable = b;
return b;
};

if (this._isAssignable !== undefined) {
return this._isAssignable;
}

const repoInfo = await this.repoInfo();
if (!repoInfo) {
return setCachedResult(false);
}

const { fm } = repoInfo;

try {
// Ensure assignable users are loaded
await fm.getAssignableUsers();
const allAssignableUsers = fm.getAllAssignableUsers();

if (!allAssignableUsers) {
return setCachedResult(false);
}
return setCachedResult(allAssignableUsers.some(user => COPILOT_LOGINS.includes(user.login)));
} catch (error) {
// If there's an error fetching assignable users, assume not assignable
return setCachedResult(false);
}
}

async isAvailable(): Promise<boolean> {
// Check if the manager is enabled, copilot API is available, and it's assignable
if (!CopilotRemoteAgentConfig.getEnabled()) {
return false;
}

if (!this.credentialStore.isAnyAuthenticated()) {
// If not signed in, then we optimistically say it's available.
return true;
}

const repoInfo = await this.repoInfo();
if (!repoInfo) {
return false;
}

const copilotApi = await this.copilotApi;
if (!copilotApi) {
return false;
}

return await this.isAssignable();
}

private firstFolderManager(): FolderRepositoryManager | undefined {
if (!this.repositoriesManager.folderManagers.length) {
return;
}
return this.repositoriesManager.folderManagers[0];
}

async repoInfo(fm?: FolderRepositoryManager): Promise<RepoInfo | undefined> {
fm = fm || this.firstFolderManager();
const repository = fm?.repository;
const ghRepository = fm?.gitHubRepositories.find(repo => repo.remote instanceof GitHubRemote) as GitHubRepository | undefined;
if (!fm || !repository || !ghRepository) {
return;
}
const baseRef = repository.state.HEAD?.name; // TODO: Consider edge cases
const preferredRemoteName = this.context.workspaceState.get(PREFERRED_GITHUB_CODING_AGENT_REMOTE_WORKSPACE_KEY);
const ghRemotes = await fm.getGitHubRemotes();
if (!ghRemotes || ghRemotes.length === 0) {
return;
}

const remote =
preferredRemoteName
? ghRemotes.find(remote => remote.remoteName === preferredRemoteName) // Cached preferred value
: (ghRemotes.find(remote => remote.remoteName === 'origin') || ghRemotes[0]); // Fallback to the first remote

if (!remote) {
Logger.error(`no valid remotes for coding agent`, CopilotRemoteAgentManager.ID);
// Clear preference, something is wrong
this.context.workspaceState.update(PREFERRED_GITHUB_CODING_AGENT_REMOTE_WORKSPACE_KEY, undefined);
return;
}

// Extract repo data from target remote
const { owner, repositoryName: repo } = remote;
if (!owner || !repo || !baseRef || !repository) {
return;
}
return { owner, repo, baseRef, remote, repository, ghRepository, fm };
}

}
5 changes: 0 additions & 5 deletions src/test/issues/issueTodoProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,8 @@
*--------------------------------------------------------------------------------------------*/

import * as vscode from 'vscode';
import { CopilotRemoteAgentManager } from '../../github/copilotRemoteAgent';
import * as issueUtil from '../../issues/util';

const mockCopilotManager: Partial<CopilotRemoteAgentManager> = {
isAvailable: () => Promise.resolve(true)
}

describe('IssueTodoProvider', function () {
// Mock isComment
// We don't have a real 'vscode.TextDocument' in these tests, which
Expand Down
Loading