Add external URI opener for PRs and issues - #8918
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new external URI opener currently reports Preferred for matching URLs even when no repository managers are available, which can hijack link opens and then fail instead of falling back to the default browser opener.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/github/externalUriOpener.ts — canOpenExternalUri returns Preferred for any matching GitHub issue/PR URL even when the… |
What changed in this PR
Adds a VS Code External URI opener so github.com/<owner>/<repo>/(pull|issues)/<number> links can be opened directly in the extension’s PR/Issue overview experience, while ensuring certain “open on GitHub” flows still force the default external opener.
Changes:
- Introduces parsing + helper API for GitHub issue/PR URLs and a “force default opener” wrapper.
- Registers an
ExternalUriOpenerthat resolves and opens PRs/issues in the corresponding overview panels. - Updates existing “open external URL” call sites to bypass contributed openers (to avoid being re-captured by the new opener).
| File | Description |
|---|---|
| src/common/externalUri.ts | Adds GitHub issue/PR URL parsing and a helper to force the default external opener. |
| src/github/externalUriOpener.ts | Registers an external URI opener that routes GitHub PR/issue links into overview panels. |
| src/github/overviewRestorer.ts | Registers the new external URI opener during extension setup. |
| src/github/pullRequestOverview.ts | Uses the “force default opener” helper for fallback external link opens. |
| src/github/pullRequestModel.ts | Uses the “force default opener” helper for “Open on GitHub”. |
| src/commands.ts | Uses the “force default opener” helper when opening PR URLs on GitHub. |
| src/test/common/externalUri.test.ts | Adds unit tests for the GitHub issue/PR URL parser. |
| src/lm/skills/summarize-github-issue-pr-notification/SKILL.md | Removes specific guidance about formatting #123 references as links. |
| package.json | Adds onOpenExternalUri:http/https activation events. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.