Skip to content

Always open Chat Customizations overview from sidebar#310871

Merged
joshspicer merged 1 commit intomainfrom
agents/remove-category-restriction-homepage
Apr 17, 2026
Merged

Always open Chat Customizations overview from sidebar#310871
joshspicer merged 1 commit intomainfrom
agents/remove-category-restriction-homepage

Conversation

@joshspicer
Copy link
Copy Markdown
Member

No description provided.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 16, 2026 23:14
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 52892575 Current: 70235632

Changed (2)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after
agentSessionsViewer/ApprovalRowLongLabel/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Agents Sessions “Chat Customizations” sidebar overview so that interacting with any overview row always opens the Chat Customizations management editor overview (rather than deep-linking into a specific section).

Changes:

  • Removed deep-linking behavior from overview items and always open the management editor overview.
  • Simplified the editor-open helper accordingly and removed the now-unused editor import.
  • Updated hover tooltip text to match the new behavior.
Show a summary per file
File Description
src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts Makes overview rows open the Chat Customizations editor overview instead of navigating to a specific section.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts:144

  • The keydown handler calls the async openOverview() without awaiting/handling the promise. Consider using an explicit fire-and-forget (void) and/or catching errors to prevent unhandled promise rejections during editor opening failures.
			this._register(DOM.addDisposableListener(sectionElement, 'keydown', (e: KeyboardEvent) => {
				if (e.key === 'Enter' || e.key === ' ') {
					e.preventDefault();
					this.openOverview();
				}
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

@joshspicer joshspicer enabled auto-merge (squash) April 17, 2026 00:57
@joshspicer joshspicer merged commit 4cd72fd into main Apr 17, 2026
44 of 45 checks passed
@joshspicer joshspicer deleted the agents/remove-category-restriction-homepage branch April 17, 2026 01:12
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 17, 2026
joshspicer added a commit that referenced this pull request Apr 17, 2026
Follow-up to #310871: the sidebar entrypoint actions (Agents, Skills,
Instructions, Hooks, MCP Servers, Plugins) still called
selectSectionById after opening the editor, which deep-linked into
the section instead of showing the overview.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joshspicer added a commit that referenced this pull request Apr 17, 2026
Follow-up to #310871: the sidebar entrypoint actions (Agents, Skills,
Instructions, Hooks, MCP Servers, Plugins) still called
selectSectionById after opening the editor, which deep-linked into
the section instead of showing the overview.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants