themes: improve quick pick focus contrast in 2026 themes#313740
Merged
hawkticehurst merged 1 commit intomainfrom May 1, 2026
Merged
themes: improve quick pick focus contrast in 2026 themes#313740hawkticehurst merged 1 commit intomainfrom
hawkticehurst merged 1 commit intomainfrom
Conversation
Update the 2026 Light and 2026 Dark quick input focused row colors to meet non-text contrast requirements against the quick input background. Also switch the focused row foreground and icon foreground to white so the stronger focus background remains legible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the 2026 Light/Dark default themes’ Quick Pick focused row colors to improve keyboard focus indicator visibility and meet the WCAG 1.4.11 (non-text contrast) 3:1 requirement against quickInput.background.
Changes:
- Strengthen
quickInputList.focusBackgroundin 2026 Light and 2026 Dark. - Set
quickInputList.focusForegroundandquickInputList.focusIconForegroundto white for legibility on the stronger focus background.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/theme-defaults/themes/2026-light.json | Uses a solid accent focus background and white focused-row text/icon colors for improved contrast in the Quick Pick. |
| extensions/theme-defaults/themes/2026-dark.json | Uses a stronger accent focus background and white focused-row text/icon colors to improve focused-row visibility on dark quick input surfaces. |
meganrogge
approved these changes
May 1, 2026
hawkticehurst
added a commit
that referenced
this pull request
May 4, 2026
… themes) (#314117) * themes: fix match highlight contrast in focused quick pick rows Add list.focusHighlightForeground: #FFFFFF to the 2026 Dark and 2026 Light themes so search match highlights remain legible against the saturated blue focused row background introduced in #313740. The original list.highlightForeground (blue) is preserved for unfocused rows, retaining the prior accessibility fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use quick-pick-specific token for focused match highlights Address review: instead of overriding the global `list.focusHighlightForeground` (which would impact all lists/trees in the workbench, including those with light tinted focus backgrounds in 2026 Light), introduce a new `quickInputList.focusHighlightForeground` color token scoped to the quick pick. Update quickInput.css to use the new token and set it to white in the 2026 Dark and 2026 Light themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307581.
Summary
This updates the focused quick pick row colors in the 2026 Light and 2026 Dark themes so they meet the 3:1 non-text contrast requirement against
quickInput.background.quickInputList.focusBackgroundin both 2026 themes to stronger accent colorsquickInputList.focusForegroundandquickInputList.focusIconForegroundto white so the focused row remains legibleWhy
The existing low-alpha focus background tints blend into the quick input surface, which makes the keyboard focus indicator too subtle in quick pick rows.