themes: fix match highlight contrast in focused quick pick rows (2026 themes)#314117
themes: fix match highlight contrast in focused quick pick rows (2026 themes)#314117hawkticehurst merged 2 commits intomainfrom
Conversation
Add list.focusHighlightForeground: #FFFFFF to the 2026 Dark and 2026 Light themes so search match highlights remain legible against the saturated blue focused row background introduced in #313740. The original list.highlightForeground (blue) is preserved for unfocused rows, retaining the prior accessibility fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This PR will be automatically cherry-picked to |
There was a problem hiding this comment.
Pull request overview
This PR aims to restore legible search match highlighting on the focused quick pick row in the 2026 Light/Dark themes after the focused-row background was changed to a saturated blue, by overriding the focused match highlight color to white.
Changes:
- Add
list.focusHighlightForeground: #FFFFFFto the 2026 Light theme. - Add
list.focusHighlightForeground: #FFFFFFto the 2026 Dark theme.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/theme-defaults/themes/2026-light.json | Overrides focused list match highlight color to white to address blue-on-blue highlights in focused quick pick rows. |
| extensions/theme-defaults/themes/2026-dark.json | Same override for the 2026 Dark theme. |
Address review: instead of overriding the global `list.focusHighlightForeground` (which would impact all lists/trees in the workbench, including those with light tinted focus backgrounds in 2026 Light), introduce a new `quickInputList.focusHighlightForeground` color token scoped to the quick pick. Update quickInput.css to use the new token and set it to white in the 2026 Dark and 2026 Light themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Addressed in 35eb2ba. Replaced the global |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Fixes #314035
#313740 increased the contrast of the focused quick pick row in the 2026 Dark and 2026 Light themes by switching the focus background to a saturated blue and the row foreground/icon foreground to white. This unfortunately caused a regression for search match highlights on the focused row: the matched substring still rendered using
list.highlightForeground(blue), producing blue text on a blue background.This PR adds
list.focusHighlightForeground: #FFFFFFto both 2026 themes so match highlights on the focused row are rendered in white — matching the focused row's foreground/icon colors. The originallist.highlightForeground(blue) is preserved for unfocused rows, retaining the prior accessibility fix.Fix:
Before:
Verified against
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com