Skip to content

[cherry-pick] themes: fix match highlight contrast in focused quick pick rows (2026 themes)#314163

Merged
hawkticehurst merged 1 commit intorelease/1.119from
cherry-pick/314117
May 4, 2026
Merged

[cherry-pick] themes: fix match highlight contrast in focused quick pick rows (2026 themes)#314163
hawkticehurst merged 1 commit intorelease/1.119from
cherry-pick/314117

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

Cherry-pick of #314117 from main.

#313740 increased the contrast of the focused quick pick row in the 2026 Dark and 2026 Light themes by switching the focus background to a saturated blue and the row foreground/icon foreground to white. This unfortunately caused a regression for search match highlights on the focused row: the matched substring still rendered using list.highlightForeground (blue), producing blue text on a blue background.

This PR adds list.focusHighlightForeground: #FFFFFF to both 2026 themes so match highlights on the focused row are rendered in white — matching the focused row's foreground/icon colors. The original list.highlightForeground (blue) is preserved for unfocused rows, retaining the prior accessibility fix.

Fix:

Screenshot 2026-05-04 at 10 52 42 AM Screenshot 2026-05-04 at 10 52 23 AM

Before:

Screenshot 2026-05-04 at 10 53 35 AM

Verified against

  1. Quick pick background (unfocused rows) — blue match highlight remains legible ✓
  2. Focused quick pick row — white match highlight is legible against the saturated blue focus background ✓

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot AI review requested due to automatic review settings May 4, 2026 17:22
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label May 4, 2026
@vs-code-engineering vs-code-engineering Bot review requested due to automatic review settings May 4, 2026 17:22
@vs-code-engineering
Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@TylerLeonhardt

Matched files:

  • src/vs/platform/quickinput/browser/media/quickInput.css

@hawkticehurst hawkticehurst merged commit 304e9e2 into release/1.119 May 4, 2026
26 checks passed
@hawkticehurst hawkticehurst deleted the cherry-pick/314117 branch May 4, 2026 17:55
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant