[cherry-pick] themes: fix match highlight contrast in focused quick pick rows (2026 themes)#314163
Merged
hawkticehurst merged 1 commit intorelease/1.119from May 4, 2026
Merged
Conversation
…ick rows (2026 themes)
Contributor
Author
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
hawkticehurst
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #314117 from
main.#313740 increased the contrast of the focused quick pick row in the 2026 Dark and 2026 Light themes by switching the focus background to a saturated blue and the row foreground/icon foreground to white. This unfortunately caused a regression for search match highlights on the focused row: the matched substring still rendered using
list.highlightForeground(blue), producing blue text on a blue background.This PR adds
list.focusHighlightForeground: #FFFFFFto both 2026 themes so match highlights on the focused row are rendered in white — matching the focused row's foreground/icon colors. The originallist.highlightForeground(blue) is preserved for unfocused rows, retaining the prior accessibility fix.Fix:
Before:
Verified against
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com