Remove IStorageSourceFilter#323480
Merged
Merged
Conversation
benibenj
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-unused IStorageSourceFilter concept from the AI Customization infrastructure, simplifying harness descriptors and prompts-service-based item enumeration so customization items are no longer filtered by per-harness storage source policy.
Changes:
- Removes
IStorageSourceFilterand the associatedapply*SourceFilterhelpers fromaiCustomizationWorkspaceService. - Simplifies
IHarnessDescriptorby removinggetStorageSourceFilter, and updates all harness descriptor producers/consumers accordingly. - Updates/cleans up tests, fixtures, and debug output to reflect the removal of storage-source filtering (including deleting the dedicated filter test suite).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/customizationHarnessService.test.ts | Updates harness descriptor test scaffolding to no longer provide getStorageSourceFilter. |
| src/vs/workbench/contrib/chat/test/browser/aiCustomization/applyStorageSourceFilter.test.ts | Removes tests for applyStorageSourceFilter after the helper/interface removal. |
| src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationListWidget.test.ts | Removes IStorageSourceFilter usage from widget tests and harness descriptors. |
| src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationItemsModel.test.ts | Removes IStorageSourceFilter usage from items model tests and harness descriptors. |
| src/vs/workbench/contrib/chat/common/customizationHarnessService.ts | Removes getStorageSourceFilter from IHarnessDescriptor and updates the empty/local descriptors accordingly. |
| src/vs/workbench/contrib/chat/common/aiCustomizationWorkspaceService.ts | Deletes IStorageSourceFilter + filter helpers (but leaves behind an outdated doc block—see review comment). |
| src/vs/workbench/contrib/chat/browser/aiCustomization/promptsServiceCustomizationItemProvider.ts | Drops active-harness filter application and returns all items (still applying builtin grouping). |
| src/vs/workbench/contrib/chat/browser/aiCustomization/customizationCreatorService.ts | Updates instantiation of PromptsServiceCustomizationItemProvider after ctor signature change. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Updates instantiation of PromptsServiceCustomizationItemProvider after ctor signature change. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationItemsModel.ts | Updates instantiation of PromptsServiceCustomizationItemProvider after ctor signature change. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationDebugPanel.ts | Updates debug report output to remove “filter” reporting and show unfiltered counts. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatContribution.ts | Removes harness descriptor getStorageSourceFilter provisioning. |
| src/vs/workbench/api/browser/mainThreadChatAgents2.ts | Removes extension-contributed harness descriptor getStorageSourceFilter provisioning. |
| src/vs/sessions/contrib/sessions/test/browser/aiCustomizationShortcutsWidget.fixture.ts | Updates fixture harness descriptor to no longer provide getStorageSourceFilter. |
| src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHostCustomizationHarness.test.ts | Updates remote-agent-host harness test descriptor to no longer provide getStorageSourceFilter. |
| src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostCustomizationHarness.ts | Removes remote-agent-host harness storage source filter plumbing. |
| src/vs/sessions/contrib/chat/browser/customizationsDebugLog.contribution.ts | Removes filtering and harness dependency from the sessions debug log contribution; logs unfiltered counts. |
| src/vs/sessions/contrib/chat/browser/aiCustomizationWorkspaceService.ts | Removes filtering logic from getFilteredPromptSlashCommands (but leaves a misleading API name/contract—see review comment). |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
52
to
56
| /** | ||
| * Per-type filter policy controlling which storage sources are visible | ||
| * for a given customization type. | ||
| */ | ||
| export interface IStorageSourceFilter { | ||
| /** | ||
| * Which storage groups to display (e.g. workspace, user, extension, builtin). | ||
| */ | ||
| readonly sources: readonly AICustomizationSource[]; | ||
| } | ||
|
|
||
| /** | ||
| * Controls which features are shown on the welcome page of the | ||
| * AI Customization Management Editor. | ||
| */ | ||
| export interface IWelcomePageFeatures { |
Comment on lines
264
to
266
| async getFilteredPromptSlashCommands(token: CancellationToken): Promise<readonly IChatPromptSlashCommand[]> { | ||
| const allCommands = await this.promptsService.getPromptSlashCommands(token); | ||
| return allCommands.filter(cmd => { | ||
| const filter = this.harnessService.getActiveDescriptor().getStorageSourceFilter(cmd.type); | ||
| return applyStorageSourceFilter([cmd], filter).length > 0; | ||
| }); | ||
| return await this.promptsService.getPromptSlashCommands(token); | ||
| } |
lszomoru
approved these changes
Jun 29, 2026
benvillalobos
added a commit
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.