Skip to content

[Cherry-Pick] Remove IStorageSourceFilter (#323480)#324810

Merged
benvillalobos merged 2 commits into
mainfrom
bv/fix-istoragesourcefilter
Jul 7, 2026
Merged

[Cherry-Pick] Remove IStorageSourceFilter (#323480)#324810
benvillalobos merged 2 commits into
mainfrom
bv/fix-istoragesourcefilter

Conversation

@benvillalobos

Copy link
Copy Markdown
Member

Related: #324669

This is a cherry-pick of PR #323480 merge commit.

Context

#323914 started from a base that existed before #323480. Merge conflict resolution accidentally ended with the version prior to #323480 being accepted.

A single merge conflict was resolved by accepting main's code, no manual change needed.

Cherry-picked from #323480's merge commit, modifying the call to
createInstance(), which no longer needs a descriptor.
Copilot AI review requested due to automatic review settings July 7, 2026 18:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cherry-picks #323480, which removes the IStorageSourceFilter abstraction and its associated helpers from the AI Customization / chat harness infrastructure. Previously, each harness descriptor exposed a getStorageSourceFilter(type) method and items were post-filtered by source; since all harnesses returned the full source set, the filter was effectively a no-op, so the mechanism is deleted to simplify the code. The cherry-pick was needed because a merge-conflict resolution in #323914 accidentally reverted to the pre-#323480 state.

Changes:

  • Remove the IStorageSourceFilter interface, the applySourceFilter/applyStorageSourceFilter helpers, and the getStorageSourceFilter member from IHarnessDescriptor.
  • Drop the now-unused getActiveDescriptor constructor parameter from PromptsServiceCustomizationItemProvider (and its applyLocalFilters method), updating all 3 call sites.
  • Remove the filter definitions from all harness descriptor factories/tests and clean up the corresponding imports.
Show a summary per file
File Description
common/aiCustomizationWorkspaceService.ts Removes IStorageSourceFilter interface and the applySourceFilter/applyStorageSourceFilter helpers; drops unused PromptsStorage import.
common/customizationHarnessService.ts Removes getStorageSourceFilter from IHarnessDescriptor, the EMPTY_FILTER constant, and descriptor filter wiring.
browser/aiCustomization/promptsServiceCustomizationItemProvider.ts Drops getActiveDescriptor ctor param and applyLocalFilters; stops applying the source filter.
browser/aiCustomization/aiCustomizationItemsModel.ts Updates provider instantiation to drop the descriptor arg.
browser/aiCustomization/aiCustomizationManagementEditor.ts Updates provider instantiation to drop the descriptor arg.
browser/aiCustomization/customizationCreatorService.ts Updates provider instantiation to drop the descriptor arg.
browser/agentSessions/agentHost/agentHostChatContribution.ts Removes getStorageSourceFilter from descriptor and unused import.
api/browser/mainThreadChatAgents2.ts Removes getStorageSourceFilter from extension-provided harness descriptor.
sessions/.../remoteAgentHost/browser/remoteAgentHostCustomizationHarness.ts Removes filter construction and getStorageSourceFilter from the remote harness descriptor.
sessions/.../aiCustomizationShortcutsWidget.fixture.ts Removes getStorageSourceFilter from the mock descriptor.
test/.../customizationHarnessService.test.ts Removes getStorageSourceFilter usages and the filter assertion.
test/.../aiCustomizationListWidget.test.ts Removes getStorageSourceFilter mock and unused imports.
test/.../aiCustomizationItemsModel.test.ts Removes getStorageSourceFilter mocks and unused IStorageSourceFilter import.
sessions/.../remoteAgentHostCustomizationHarness.test.ts Removes getStorageSourceFilter mock and unused import.

Review details

  • Files reviewed: 14/14 changed files
  • Comments generated: 0
  • Review effort level: Medium

@benvillalobos benvillalobos marked this pull request as ready for review July 7, 2026 18:42
@benvillalobos benvillalobos enabled auto-merge (squash) July 7, 2026 18:46
@benvillalobos benvillalobos requested a review from aeschli July 7, 2026 18:50
@benvillalobos benvillalobos merged commit 278ac59 into main Jul 7, 2026
29 checks passed
@benvillalobos benvillalobos deleted the bv/fix-istoragesourcefilter branch July 7, 2026 19:03
@vs-code-engineering vs-code-engineering Bot added this to the 1.129.0 milestone Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants