Skip to content

Modern UI: Enhance tab design for improved accessibility and usability - #329145

Merged
mrleemurray merged 23 commits into
mainfrom
mrleemurray/maximis-tab-size
Aug 5, 2026
Merged

Modern UI: Enhance tab design for improved accessibility and usability#329145
mrleemurray merged 23 commits into
mainfrom
mrleemurray/maximis-tab-size

Conversation

@mrleemurray

@mrleemurray mrleemurray commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces significant improvements to the visual appearance and structure of editor tabs, focusing on the Modern UI style. The changes add a new .tab-fill element for pill-shaped backgrounds, refine tab padding and spacing, and update how tab backgrounds and hit areas are rendered. There are also several adjustments to spacing and layout to ensure consistency, accessibility, and better alignment with the Modern UI design guidelines.

Modern UI Tab Rendering Enhancements:

  • Added a new .tab-fill element to each tab in MultiEditorTabsControl for rendering pill-shaped backgrounds, which allows for more flexible and visually consistent styling. [1] [2]
  • Updated CSS to display .tab-fill as the pill background in Modern UI, with different background colors for hover, selected, and active states, and ensured it does not interfere with tab content or hit areas.

Tab Spacing and Layout Adjustments:

  • Refined tab and container padding, using CSS variables for consistency and improved accessibility, including special handling for high-contrast themes. [1] [2] [3] [4]
  • Adjusted the minimum height and border of tabs to expand the clickable area without affecting the label or indicator layout, especially in non-high-contrast Modern UI.

Cleanup and Removal of Redundant Styles:

  • Removed old background color rules and redundant styles for compact sticky tabs, as these are now handled by the new .tab-fill approach. [1] [2] [3]

These changes collectively modernize the tab appearance, improve accessibility, and lay the groundwork for further UI enhancements.

Resolves #325256
Resolves #328765

Copilot AI balanced review requested due to automatic review settings August 5, 2026 10:01
@mrleemurray
mrleemurray enabled auto-merge (squash) August 5, 2026 10:01
@mrleemurray mrleemurray self-assigned this Aug 5, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@benibenj

Matched files:

  • src/vs/workbench/browser/parts/editor/media/multieditortabscontrol.css
  • src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces pill-style Modern UI editor tabs with larger hit areas and updated state styling.

Changes:

  • Adds a decorative tab-fill element.
  • Updates tab spacing, sizing, and state backgrounds.
  • Preserves default styling outside Modern UI.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tabs.css Implements Modern UI pill styling and hit areas.
multiEditorTabsControl.ts Adds the decorative tab-fill element.
multieditortabscontrol.css Hides tab fills outside Modern UI.

Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/tabs.css Outdated
Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/tabs.css
Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/tabs.css Outdated
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 8662518b Current: 0e8c3411

Changed (81)

sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Dark
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/Default/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/Default/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/Default/DarkHighContrast
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllPinned/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllPinned/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllUnpinned/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllUnpinned/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowMixed/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowMixed/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowMixed/DarkHighContrast
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsFilePathLast/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsFilePathLast/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsIconsOff/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsIconsOff/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingShrink/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingShrink/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingFixed/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingFixed/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabHeightCompact/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabHeightCompact/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/WrapTabs/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/WrapTabs/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionLocationLeft/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionLocationLeft/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionCloseHidden/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionCloseHidden/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionUnpinHidden/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionUnpinHidden/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ShowTabIndex/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ShowTabIndex/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/HighlightModifiedTabs/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/HighlightModifiedTabs/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatShort/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatShort/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatMedium/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatMedium/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatLong/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatLong/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ShowIconsOff/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ShowIconsOff/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/DecorationsOff/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/DecorationsOff/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingCompact/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingCompact/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingShrink/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingShrink/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarLarge/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarLarge/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarVisible/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarVisible/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsDefault/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsDefault/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsTitleBar/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsTitleBar/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsHidden/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsHidden/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsActiveGroup/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsActiveGroup/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsInactiveGroup/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsInactiveGroup/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ActiveGroup/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ActiveGroup/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroup/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroup/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroup/DarkHighContrast
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/MultiSelect/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/MultiSelect/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/MultiSelect/DarkHighContrast
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroupDirty/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroupDirty/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LongLabelsShrink/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/LongLabelsShrink/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/DropTargetBetweenTabs/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/DropTargetBetweenTabs/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/DropTargetBetweenTabs/DarkHighContrast
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/StickyCompactNoIcons/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/StickyCompactNoIcons/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedSeparateRowCompact/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedSeparateRowCompact/Light
Before After
before after

…th calculations

Co-authored-by: Copilot <copilot@github.com>
@mrleemurray
mrleemurray marked this pull request as draft August 5, 2026 10:23
auto-merge was automatically disabled August 5, 2026 10:23

Pull request was converted to draft

mrleemurray and others added 11 commits August 5, 2026 11:38
… bars

Co-authored-by: Copilot <copilot@github.com>
…container

Co-authored-by: Copilot <copilot@github.com>
…o-tab-bars layout

Co-authored-by: Copilot <copilot@github.com>
…ontrast themes

Co-authored-by: Copilot <copilot@github.com>
…stency

Co-authored-by: Copilot <copilot@github.com>
…acing

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…nding with UI elements

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…al spacing

Co-authored-by: Copilot <copilot@github.com>
@mrleemurray
mrleemurray marked this pull request as ready for review August 5, 2026 12:19
DonJayamanne
DonJayamanne previously approved these changes Aug 5, 2026
@mrleemurray
mrleemurray merged commit 758196a into main Aug 5, 2026
29 checks passed
@mrleemurray
mrleemurray deleted the mrleemurray/maximis-tab-size branch August 5, 2026 17:13
@vs-code-engineering vs-code-engineering Bot added this to the 1.133.0 milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modern UI has reduced click targets Fitt's Law violated in v1.129

5 participants