Agents: refine pull request input banners - #333428
Merged
Benjamin Christopher Simmonds (benibenj) merged 3 commits intoAug 31, 2026
Merged
Agents: refine pull request input banners#333428Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
August 30, 2026 20:34
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Refines Agents Window pull request banners while improving review-state resilience and feedback attribution.
Changes:
- Consolidates banner actions and improves responsive/accessibility behavior.
- Preserves current actions across refreshes and exposes partial review results.
- Retains PR attribution and handles unknown PR icons safely.
| File | Description |
|---|---|
sessionInputBannerWidget.test.ts |
Tests split actions and action freshness. |
sessionInputBanners.test.ts |
Updates banner behavior assertions. |
sessionInputBanners.fixture.ts |
Adds narrow and multi-PR fixtures. |
sessionInputBannerWidget.ts |
Resolves actions against current state. |
sessionInputBanners.ts |
Simplifies labels, references, and actions. |
sessionInputBanners.css |
Preserves intrinsic action widths. |
copilotChatSessionsProvider.ts |
Supplies the single-PR fallback icon. |
localAgentHostSessionsProvider.test.ts |
Verifies unknown secondary PR state. |
baseAgentHostSessionsProvider.ts |
Limits fallback icons to the first PR. |
githubModels.test.ts |
Tests undefined icons in priority selection. |
pullRequestIconStatus.ts |
Makes fallback icons optional. |
pullRequestActions.ts |
Handles unknown icons in pills and pickers. |
githubPullRequestReviewThreadsModel.ts |
Tracks initial refresh completion. |
codeReviewService.test.ts |
Tests partially failed PR loading. |
codeReviewService.ts |
Exposes healthy comments with incomplete PRs. |
sessionsChatAccessibilityHelp.ts |
Updates localized banner guidance. |
sessionEditorComments.test.ts |
Adapts review-state fixtures. |
agentFeedbackService.test.ts |
Tests attribution backfilling. |
agentFeedbackPRReviewSeeder.test.ts |
Tests legacy and incomplete snapshots. |
agentFeedbackEditorWidget.test.ts |
Tests PR identity preservation. |
nullAgentFeedbackService.contribution.ts |
Implements the new no-op API. |
agentFeedbackService.ts |
Adds non-destructive attribution updates. |
agentFeedbackPRReviewSeeder.ts |
Backfills and preserves PR-scoped mirrors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (24)
|
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CIFailures/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CIFailuresLoading/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CIFailuresLoading/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/Comments/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/Comments/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CommentsLoading/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CommentsLoading/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/PRComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/PRComments/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/AgentComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/AgentComments/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/Both/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/Both/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/MultiplePullRequests/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/MultiplePullRequests/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CombinedNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/CombinedNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/LongTextEllipsis/Dark
| Before | After |
|---|---|
 |
 |
sessions/inputBanners/sessionInputBanners/LongTextEllipsis/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_DebugFakeData/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_DebugFakeData/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_HorizontalOverflow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_HorizontalOverflow/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (2)
sessions/inputBanners/sessionInputBanners/CommentsNarrow/Dark
sessions/inputBanners/sessionInputBanners/CommentsNarrow/Light
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 31, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Aug 31, 2026
bfafa1a
into
main
37 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/input-banner-follow-up
branch
August 31, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #333189.
Test plan