sessions: Use concise nested chat delete label - #333743
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoSep 1, 2026
Merged
sessions: Use concise nested chat delete label#333743Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Use a concise ellipsis label in the scoped nested-chat menu while preserving explicit wording on other surfaces. Add focused coverage for labels and the confirmation path. Fixes #333677 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 1, 2026 09:43
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 1, 2026 09:44
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/sessions/browser/sessionsActions.ts — Use three periods here to match the established action-label convention. The sibling action is… |
What changed in this PR
Updates nested-chat deletion wording while preserving explicit labels elsewhere.
Changes:
- Shortens the nested-chat context-menu label.
- Verifies confirmation is not bypassed.
- Adds regression coverage for labels across surfaces.
| File | Description |
|---|---|
sessionsActions.ts |
Updates the nested-chat delete label. |
sessionsActions.test.ts |
Verifies the Command Palette label. |
sessionsListContextMenu.test.ts |
Tests context-menu labels and deletion options. |
sessionsListTestUtils.ts |
Records deletion options in the test service. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Sep 1, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/update-delete-chat-menu-label
branch
September 1, 2026 10:35
Bhavya U (bhavyaus)
pushed a commit
that referenced
this pull request
Sep 1, 2026
* sessions: Update nested chat delete action label Use a concise ellipsis label in the scoped nested-chat menu while preserving explicit wording on other surfaces. Add focused coverage for labels and the confirmation path. Fixes #333677 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: Use consistent delete action ellipsis Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete ChattoDelete…Delete Chatlabel on the Command Palette and chat-tab surfacesFixes #333677
Validation
npm run compilenpm run hygienenpm run typecheck-client./scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsActions.test.ts --run src/vs/sessions/contrib/sessions/test/browser/sessionsListContextMenu.test.ts