Reliably diagnose stack allocations in C++/WinRT breaks the Xaml compiler#343
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan and
devhawk
as code owners
Scottj1s
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xaml compiler has a bug where it generates
std::shared_ptr<T>instead ofwinrt::com_ptr<T>for WinRT types. This has always been wrong because it breaks the lifetime guarantee of the implementation. The newly introduced diagnostics in C++/WinRT correctly flags this invalid use with a compiler error. Unfortunately, fixing the Xaml compiler may take some time so we need an opt-out for projects using the Xaml compiler until a fix is available. Now projects can defineWINRT_NO_MAKE_DETECTIONto turn off the detection of direct allocations.