Skip to content

Reliably diagnose stack allocations in C++/WinRT breaks the Xaml compiler #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 1 commit into from
Apr 23, 2019
Merged

Reliably diagnose stack allocations in C++/WinRT breaks the Xaml compiler #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tool/cppwinrt/strings/base_collections_input_iterable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace winrt::impl
return range_container<InputIt>{ m_begin, m_end };
}

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
void use_make_function_to_create_this_object() final
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/tool/cppwinrt/strings/base_collections_input_map_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace winrt::impl
return m_values;
}

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
void use_make_function_to_create_this_object() final
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/tool/cppwinrt/strings/base_collections_input_vector_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace winrt::impl
return range_container<InputIt>{ m_begin, m_end };
}

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
void use_make_function_to_create_this_object() final
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/tool/cppwinrt/strings/base_coroutine_foundation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ namespace winrt::impl
cancel();
}

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
void use_make_function_to_create_this_object() final
{
}
Expand Down
4 changes: 2 additions & 2 deletions src/tool/cppwinrt/strings/base_implements.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ namespace winrt::impl
{
using T::T;

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
void use_make_function_to_create_this_object() final
{
}
Expand Down Expand Up @@ -1263,7 +1263,7 @@ namespace winrt
using implements_type = implements;
using IInspectable = Windows::Foundation::IInspectable;

#ifdef _DEBUG
#if defined(_DEBUG) && !defined(WINRT_NO_MAKE_DETECTION)
// Please use winrt::make<T>(args...) to avoid allocating a C++/WinRT implementation type on the stack.
virtual void use_make_function_to_create_this_object() = 0;
#endif
Expand Down