fix(shared): stop Queue.pull treating undefined as the empty sentinel - #50
Merged
Merged
Conversation
pull() shifted first and tested the result against undefined, so a legitimately buffered undefined value was consumed, discarded, and the pull parked despite later buffered items. Check items.length before shifting instead, matching push(), which already hands undefined to a waiting resolver.
@standardserver/aws-lambda
@standardserver/bun
@standardserver/core
@standardserver/deno
@standardserver/fastify
@standardserver/fetch
@standardserver/node
@standardserver/peer
@standardserver/shared
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue.pull() shifted the buffer first and then tested the result against undefined, so a legitimately buffered undefined value was consumed and discarded while the pull parked despite later buffered items — the value was lost and pull ordering inverted. pull() now checks the buffer length before shifting, matching push(), which already hands undefined straight to a waiting resolver.
Fixes
Queue<string | undefined>(and similar) no longer loses pushedundefinedvalues; pulls return them in order instead of parking.Queueis publicly exported with unconstrainedT, so external consumers were exposed.Testing
push(undefined)thenpush('a')pulls backundefinedthen'a'in order.