Skip to content

fix(shared): stop Queue.pull treating undefined as the empty sentinel #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Aug 3, 2026
Merged

fix(shared): stop Queue.pull treating undefined as the empty sentinel #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/shared/src/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ describe('queue', () => {
expect(await queue.pull()).toBe('b')
})

it('returns buffered undefined items in order', async () => {
const queue = new Queue<string | undefined>()

queue.push(undefined)
queue.push('a')

expect(await queue.pull()).toBeUndefined()
expect(await queue.pull()).toBe('a')
})

it('resolves a pending pull on push', async () => {
const queue = new Queue<string>()

Expand Down
6 changes: 2 additions & 4 deletions packages/shared/src/queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ export class Queue<T> {
* @throws when the queue is closed or aborted. Note that buffered items can still be pulled after close until the buffer is drained.
*/
async pull(): Promise<T> {
const item = this.items.shift()

if (item !== undefined) {
return item
if (this.items.length > 0) {
return this.items.shift() as T
}

if (this.closed) {
Expand Down
Loading