fix(policy): trim the memory service prefix from condition key names

[harshavardhana]

Follow-up to #251, which added memory:prefix and memory:max-keys. Both were
inert as shipped.

A condition key's service prefix is stripped before it looks up the request
value — toTrim covers aws, jwt, ldap, sts, svc, s3, s3tables —
so s3:prefix reads the request's prefix. memory was missing:

s3:prefix     .Name() = "prefix"
memory:prefix .Name() = "memory:prefix"
evaluate against args[prefix]=alpha -> false

The key parsed, validated, and appeared in the action condition map, so a policy
using it loaded cleanly — and then granted nothing, because the condition never
matched. That is the failure mode the key was added to prevent: a grant that
looks scoped and silently isn't.

After the fix:

memory:prefix .Name() = "prefix"
prefix=alpha    vs alpha* -> true
prefix=alphabet vs alpha* -> true
prefix=beta     vs alpha* -> false
prefix absent             -> false

Tests assert the request-name mapping for every service-prefixed key, not just
the memory ones, so the next service added here fails loudly rather than
shipping inert. Mutation-checked: removing memory from toTrim fails both.

[coderabbitai]

Warning

Review limit reached

@harshavardhana, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0d43a268-60b6-4488-a391-cf938435a506

📥 Commits

Reviewing files that changed from the base of the PR and between aa4efcb and d617655.

📒 Files selected for processing (2)

• policy/condition/keyname.go
• policy/condition/keyname_test.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR fixes policy condition evaluation for memory:-prefixed condition keys by ensuring the service prefix is trimmed before request-argument lookup, making memory:prefix and memory:max-keys effective rather than inert.

Changes:

• Add memory to the set of service prefixes trimmed from condition key names.
• Add unit tests intended to guard the key-name → request-argument mapping and to verify memory:prefix conditions evaluate against the real request prefix value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
policy/condition/keyname.go	Adds "memory" to the toTrim prefix set so memory:* keys resolve to request argument names.
policy/condition/keyname_test.go	Introduces tests for service-prefixed key name resolution and for memory:prefix condition evaluation behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.