Skip to content

Conversation

@odlbot
Copy link
Contributor

@odlbot odlbot commented Mar 18, 2024

Shankar Ambady

renovate[bot]

shanbady and others added 15 commits March 12, 2024 14:49
* adding initial model for program letter and display

* adding program letter model

* adding initial intercept and display views

* added letter rendering view, initial template and fixed programletter model

* adding view tests

* template cleanup and more tests

* adding more coverage

* adding coverage

* adding more coverage

* adding reference implementation for program letter display

* frontend style lint and removing old view

* fixing test

* adding api view test

* regenerate openapi spec

* fixing lint errors and updated schema

* some cleanup and addition of footer

* test fixes and lint

* add missing class

* adding coverage

* lint

* adding coverage

* lint

* adding missing docstrings

* updating schema

* adding uuid check on program letter api and test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…608)

* adding program certificate endpoint and tests

* making view filterable

* updating open api schema

* lint fix

* making program letter urls absolute and adding share urls

* updating openapi spec

* updating factory for new fields

* fixing test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#617)

* adding working migrations to use external schema

* adding migration to set programcertificates to unmanaged

* fixing tests and adding test for routers

* fixing router argument

* adding doc
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 52.85714% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 50.32%. Comparing base (7b3aa05) to head (12004cc).

Files Patch % Lines
frontends/api/src/generated/api.ts 12.50% 28 Missing ⚠️
...nds/api/src/test-utils/factories/programLetters.ts 33.33% 2 Missing ⚠️
frontends/api/src/clients.ts 83.33% 1 Missing ⚠️
frontends/api/src/test-utils/urls.ts 66.66% 1 Missing ⚠️
.../src/pages/ProgramLetterPage/ProgramLetterPage.tsx 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release     #630       +/-   ##
============================================
- Coverage    74.68%   50.32%   -24.37%     
============================================
  Files          243      102      -141     
  Lines        11015     4626     -6389     
  Branches      1926      979      -947     
============================================
- Hits          8227     2328     -5899     
+ Misses        2617     2243      -374     
+ Partials       171       55      -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants